Ticket #10299 (new defect)

Opened 4 years ago

Last modified 3 years ago

add olpc-pwrlogs to build

Reported by: rsmith Owned by:
Priority: high Milestone: Future Release
Component: olpc-utils Version: Development build as of this date
Keywords: Cc: dsd
Action Needed: package Verified: no
Deployments affected: Blocked By:
Blocking:

Description

I've discovered that olpc-pwr-log in the build is broken with the newer kernel on XO-1.

olpc-pwr-log is currently part of olpc-utils but I now have a family of log scripts and a python program that will process them.

I have created a new repository that has all my code and created an rpm package for them. The package is called olpc-pwrlogs and the current release is in my public_rpms dir.

Please add this to the next build and remove olpc-pwr-log from olpc-utils.

The git repo can be found at:

git://dev.laptop.org/users/rsmith/olpc-pwrlogs

Attachments

olpc-pwr-log (5.4 kB) - added by rsmith 4 years ago.

Change History

  Changed 4 years ago by Quozl

  • next_action changed from never set to add to build
  • milestone changed from Not Triaged to 10.1.2

  Changed 4 years ago by dsd

This has missed the freeze deadline for 10.1.2. I think we should fix olpc-pwr-log in olpc-utils for 10.1.2 (probably something simple, right?), and schedule olpc-pwrlogs for 10.1.3.

  Changed 4 years ago by Quozl

  • milestone changed from 10.1.2 to 10.1.3

Changed 4 years ago by rsmith

  Changed 4 years ago by rsmith

ok. New olpc-pwr-log attached to ticket. Please commit to olpc-utils

  Changed 4 years ago by Quozl

  • priority changed from normal to blocker
  • milestone changed from 10.1.3 to 10.1.2

follow-up: ↓ 7   Changed 4 years ago by dsd

  • cc dsd added

I assume the breakage is that the Net ACR field shows ridiculously high values.

This does not seem to be fixed in the latest version attached above. The values are still very wacky.

in reply to: ↑ 6   Changed 4 years ago by rsmith

Replying to dsd:

I assume the breakage is that the Net ACR field shows ridiculously high values. This does not seem to be fixed in the latest version attached above. The values are still very wacky.

I'll recheck but the issue is that the kernel API changed from reporting a raw sesor read 2's complement number to a processed +/- value in uAh similar to like what it does for V and I. So yes the number is quite large to previous versions but it is correct.

  Changed 4 years ago by dsd

  • next_action changed from add to build to test in build

pushed olpc-utils-1.0.28, simple test case is not overly clear to me. perhaps:

17:45 < smithbone> dsd_: Most of the "bug" part of that is in my processing 
                   scripts where I have to know what the number is in order to 
                   calculate the power.  I think if you wanted to verify 
                   operation properly then you would check that KERVER and thus 
                   KERNAPI get set correctly. Where 1 is the old api (802) and 
                   2 is the new. Then verify that works properly on build 802 
                   and 851 (XO1 and XO1.5)

  Changed 4 years ago by cjb

test in os852

  Changed 4 years ago by Quozl

olpc-utils-1.0.28 is present on os852 after install.

follow-ups: ↓ 12 ↓ 13   Changed 4 years ago by Quozl

  • next_action changed from test in build to testcase

On XO-1 with a fresh install of os852.

/home/olpc/power-logs/ is being populated and the data looks okay to me, but I don't know what I'm meant to be looking for. BUILD says 852. KERNAPI was not present. KERNVER appears to be uname -a. Aha, I guess olpc-pwr-log.sh is being used from /etc/powerd/. But it is meant to use a LOGDIR of /home/olpc/olpc-pwr-logs/ ... I'm confused.

/usr/bin/olpc-pwr-log is present as part of the olpc-utils package. Can't see how it is called.

An olpc-pwrlogs package is not present.

in reply to: ↑ 11   Changed 4 years ago by rsmith

Replying to Quozl:

On XO-1 with a fresh install of os852. /home/olpc/power-logs/ is being populated and the data looks okay to me, but I don't know what I'm meant to be looking for. BUILD says 852. KERNAPI was not present. KERNVER appears to be uname -a. Aha, I guess olpc-pwr-log.sh is being used from /etc/powerd/. But it is meant to use a LOGDIR of /home/olpc/olpc-pwr-logs/ ... I'm confused.

Different systems. powerd logs some of the same information as olpc-pwr-log but its use is very different than that of olpc-pwr-log. Treat them as totally separate from each other. They don't interact.

/usr/bin/olpc-pwr-log is present as part of the olpc-utils package. Can't see how it is called.

olpc-pwr-log is meant to be called by the user from the terminal when they want to take specific measurements of power use or want to determine the capacity of their battery.

in reply to: ↑ 11   Changed 4 years ago by rsmith

Replying to Quozl:

An olpc-pwrlogs package is not present.

rpm not added yet. just updated the existing olpc-utils with my latest script.

  Changed 4 years ago by Quozl

(Withdrawn has been build os852 mentioned above this point in ticket history. 96379866c972367f40ec3e8accbaef49 os852.img)

  Changed 4 years ago by Quozl

  • milestone changed from 10.1.2 to 10.1.3

  Changed 4 years ago by Quozl

  • priority changed from blocker to high

  Changed 3 years ago by erikos

Ping what is the status here? Anything that should be included in the next build? You can stage it in the public_rpms for inclusion.

  Changed 3 years ago by rsmith

The new rpm was not getting included because I didn't have it in the right spot. The rpm is now in my f11 dir and should be picked up in the next build.

follow-up: ↓ 20   Changed 3 years ago by dsd

Richard, do you definitely want this as a separate package?

Given that its just a small collection of utilities it would be less packaging overhead just to keep them all in 1 place.

Continually adding more non-Fedora packages like this just makes our stuff harder to maintain in the long run.

What do you think about just including it all in olpc-utils?

in reply to: ↑ 19   Changed 3 years ago by rsmith

Replying to dsd:

Richard, do you definitely want this as a separate package? Given that its just a small collection of utilities it would be less packaging overhead just to keep them all in 1 place. Continually adding more non-Fedora packages like this just makes our stuff harder to maintain in the long run. What do you think about just including it all in olpc-utils?

Thats how it was until I made a new package. I made a new package since it was much easier to release rather than go bother the olpc-utils maintainer to include my latest changes.

Keeping it all in olpc-utils is fine with me. I just need a official method of putting my changes into that package.

  Changed 3 years ago by erikos

http://dev.laptop.org/git/projects/olpc-utils/

Who is the official maintainer? Martin, Daniel and Paul seem to have write access.

  Changed 3 years ago by erikos

  • next_action changed from testcase to package

Any news on this one?

  Changed 3 years ago by dsd

Richard, you should just ask Chris for commit access to olpc-utils, then he or I can make a release when you need one.

  Changed 3 years ago by erikos

  • milestone changed from 10.1.3 to Future Release

Moving this out, as we are already late in the cycle.

Note: See TracTickets for help on using tickets.