Ticket #10302 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Game not transfered when loading a created game

Reported by: erikos Owned by: erikos
Priority: normal Milestone: 10.1.3
Component: memorize Version: Development build as of this date
Keywords: Cc: godiard, greenfeld
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Version: 850, Memorize 34

Steps to reproduce: Machine A: - Create a game in Memorize - share the activity - load the new game Machine B: - Join shared activity

---> the presence information is transferred, the game not.

Log:

1281706854.822899 DEBUG memorize-activity: buddy joined: erich
1281706854.823570 DEBUG memorize-activity: Buddy 'erich' was added to game
1281706854.889342 DEBUG root: <Buddy object at 0x9acd39c (sugar+presence+buddy+Buddy at 0x9a95e20)>
1281706855.531542 ERROR dbus.connection: Exception in handler for D-Bus signal:
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/dbus/connection.py", line 214, in maybe_handle_message
    self._handler(*args, **kwargs)
  File "/home/olpc/Activities/Memorize.activity/messenger.py", line 88, in _hello_receiver
    path)
  File "/usr/lib/python2.6/site-packages/dbus/proxies.py", line 68, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib/python2.6/site-packages/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/python2.6/site-packages/dbus/connection.py", line 630, in call_blocking
    message, timeout)
DBusException: org.freedesktop.DBus.Python.KeyError: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/dbus/service.py", line 702, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/home/olpc/Activities/Memorize.activity/messenger.py", line 96, in load_game
    self._change_game_receiver(data['mode'], grid, data, path)
  File "/home/olpc/Activities/Memorize.activity/messenger.py", line 140, in _change_game_receiver
    self.game.model.read(self.files[path])
KeyError: dbus.String(u'/home/olpc/.sugar/default/data/fed147b8-d3b8-4282-bef3-84397e5f64f3_2')

Attachments

0001-Make-sure-a-created-game-is-transferred-when-a-user-.patch Download (1.5 KB) - added by erikos 4 years ago.
Make sure to listen to file transfers and that we get the files

Change History

Changed 4 years ago by erikos

  • summary changed from Game not transfered when loadng a created game to Game not transfered when loading a created game

Changed 4 years ago by erikos

This is definitely a Memorize only issue, no need to worry about sharing on 850 in general.

Changed 4 years ago by garycmartin

Was tinkering with this issue (raised on the mail-list) there is a work around for sharing custom games that may help hunt the bug. See  http://bugs.sugarlabs.org/ticket/2115#comment:6

Changed 4 years ago by erikos

Thanks Gary for the comment. Yes your findings are the same than mine. The exact sequence to trigger the bug is:

A: - Create a game in Memorize

- share the activity

- load the new game Machine

B: - Join shared activity

When you shared first another game and load then the created one it works. Should be doable to figure out what is going wrong.

Changed 4 years ago by erikos

Make sure to listen to file transfers and that we get the files

Changed 4 years ago by erikos

  • next_action changed from diagnose to review

The above patch does handle the case for me.

I came across another issue (which I am quite sure has not been introduced by my patch) that when you join a shared activity on more than one machine quickly after each other they get out of sync. The member ordering is different on one machine, hence they can not play together. We should see if that one can be fixed, too.

Changed 4 years ago by erikos

  • milestone changed from Not Triaged to 10.1.3

I will do another test round tomorrow. A

As I just came across the issue today in my school once more I think we should include a fix in 10.1.3.

Changed 4 years ago by godiard

  • cc godiard added

Changed 4 years ago by erikos

  • next_action changed from review to add to build

Changed 4 years ago by erikos

  • cc greenfeld added

Changed 4 years ago by erikos

  • next_action changed from add to build to test in build

In os351.

Changed 4 years ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

Verified on 10.1.3 os352 with both ad-hoc and schoolserver-based connections that a custom game (with sound & pictures) as well as the included example games were transferred properly between XOs. Testing was done both when connecting to an existing game as well as loading a new game to play.

Note: See TracTickets for help on using tickets.