Journal does not provide any error message on write errors

[erikos]

http://bugs.sugarlabs.org/ticket/1842

I want to track the back port of the patch to 0.84 here. Landed in 0.90. The master patch does depend on new API in sugar-toolkit, the 0.84 should just create the Alert inside the patch.

[erikos]

Journal: add error message on copy to device errors (patch for 0.84)

[erikos]

Refined the master patch and attached the patch for 0.84. I would to include it in 10.1.3 as it has been originally requested from the field. The only issue is that it introduces strings which we need the translations for.

[erikos]

|TestCase|

- insert an usb device
- drag an entry with no file associated (e.g. log entry) on the device (main view)
---> Alert that you can not copy an entry that has no file.
- go to the detail view of a log entry and copy onto the device
---> Alert that you can not copy an entry that has no file.

- insert an usb device that is write protected
- drag an entry with a file associated (e.g. screenshot) on the device (main view)
---> Alert: Permission denied
- go to the detail view of a screenshot and copy onto the device
---> Alert: Permission denied

[greenfeld]

Test RPMs used:

• sugar-0.84.22-2.fc11.i586.rpm
• sugar-artwork-0.84.2-2.fc11.i586.rpm
• sugar-presence-service-0.84.1-2.fc11.noarch.rpm
• sugar-toolkit-0.84.12-2.fc11.i586.rpm

If the disk is full, these RPMs detect it and display an error message.

However I could NOT get these RPMs to display any errors if Linux had USB or SD media mounted as read-only, either via remounting USB media that lacked a write switch (as root: /sbin/mount /mount/your_usb_stick -o ro,remount), or by using an SD card with a write switch on it (which the OS detects and will mount media as ro/rw as appropriate). Any error message caught is not displayed to the user when this happens.

More investigation may be needed.

[erikos]

Good catch! We do only listen for IOError, but OSError is raised when we do not have enough permissions. Will do a new patch.

[erikos]

I have updated the rpm: http://dev.laptop.org/~erikos/sugar-0.84.22-2.fc11.i586.rpm

Can you give it another try?

[erikos]

Hmm, interesting on 0.90 we get the IOError when we do not have write permissions. That is why the code did work when i tested it for me. The RPM above does catch as well the OSError so it will work - will have a look if there were some changes.

[erikos]

Pushed as: http://git.sugarlabs.org/projects/sugar/repos/mainline/commits/63a44627b3f712eeaff0cb6e1e0c552f9a32f7f6

Is available in os350.

[greenfeld]

The Test cases mentioned above work in 10.1.3 os351 on both an XO-1 and a XO-1.5.

However no error message appears if the disk is full. But this is not a test case mentioned above. I tried almost filling up the internal flash drive and then copying things from the USB stick and no error message appeared.

Is a check for the latter behavior supposed to be in this patch?

[erikos]

Replying to greenfeld:

The Test cases mentioned above work in 10.1.3 os351 on both an XO-1 and a XO-1.5. However no error message appears if the disk is full. But this is not a test case mentioned above. I tried almost filling up the internal flash drive and then copying things from the USB stick and no error message appeared. Is a check for the latter behavior supposed to be in this patch?

Yes, the case you are mentioning is indeed not handled by the fixes in here. This case does handle errors when copying from the Journal to an external device.

So if I read your lines correct, you would expect an error message appear when your disk is full and you copy things from an external device to the Journal, correct? And being proactive like we do with the "Your Journal is full message" that appears when the remaining size is below 50 mb? (this should go into a separate bug if)

[erikos]

Replying to erikos:

Replying to greenfeld:

The Test cases mentioned above work in 10.1.3 os351 on both an XO-1 and a XO-1.5. However no error message appears if the disk is full. But this is not a test case mentioned above. I tried almost filling up the internal flash drive and then copying things from the USB stick and no error message appeared. Is a check for the latter behavior supposed to be in this patch?

Yes, the case you are mentioning is indeed not handled by the fixes in here. This case does handle errors when copying from the Journal to an external device. So if I read your lines correct, you would expect an error message appear when your disk is full and you copy things from an external device to the Journal, correct? And being proactive like we do with the "Your Journal is full message" that appears when the remaining size is below 50 mb? (this should go into a separate bug if)

Sam, can we close this ticket (and open a new ticket if necessary), given my response from above?

[greenfeld]

Since it is just comment confusion suggesting this fix does more taking it back for testing/closing.

[greenfeld]

We now get an error message if the file system we are writing to is read-only or lacks the proper permissions for us to write in 10.1.3 os354.