Opened 4 years ago

Closed 4 years ago

#10346 closed defect (fixed)

Title change is not always recognized

Reported by: erikos Owned by: erikos
Priority: normal Milestone: 10.1.3
Component: sugar-toolkit Version: Development build as of this date
Keywords: Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

Steps to reproduce:

  • open activity
  • change title
  • close activity directly

If you switch first to another activity it is not triggered. This is the case since new code which was introduced uses the 'focus-out' event. http://bugs.sugarlabs.org/ticket/1948#comment:13

I will think a moment what the best solution is - but I think the simplest is to use Aleksey's patch.

Attachments (1)

0001-Save-title-when-closing-1948.patch (2.0 KB) - added by erikos 4 years ago.
save title when hitting stop button - disconnect the focus-out handler

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by erikos

save title when hitting stop button - disconnect the focus-out handler

comment:1 Changed 4 years ago by erikos

  • Action Needed changed from code to review

I tested if the focus-out event is propagated. When hitting stop the focus-out is emitted, though we do save first. I have added now a line that just saves the title when hitting stop. Furthermore the focus-out-event handler is disconnected to not receive events when the activity is deconstructed (can be seen in current code).

comment:2 Changed 4 years ago by erikos

  • Action Needed changed from review to package
  • Milestone changed from Not Triaged to 10.1.3

comment:3 Changed 4 years ago by erikos

|TestCase|

  • open activity
  • change title
  • close activity directly

comment:4 Changed 4 years ago by greenfeld

Tested with various activities and the following test RPMs:
sugar-0.84.22-2.fc11.i586.rpm
sugar-artwork-0.84.2-2.fc11.i586.rpm
sugar-presence-service-0.84.1-2.fc11.noarch.rpm
sugar-toolkit-0.84.12-2.fc11.i586.rpm

Attempted to change the title assigned to an activity session and then immediately press the Stop button to exit out of said activity. The title change was remembered in each case.

comment:6 Changed 4 years ago by erikos

  • Action Needed changed from package to test in build

Is available in os350.

comment:7 Changed 4 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

Tested that this fix still works in 10.1.3 os351 on both XO-1 and XO-1.5 with various activities.

Note: See TracTickets for help on using tickets.