Ticket #10346 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Title change is not always recognized

Reported by: erikos Owned by: erikos
Priority: normal Milestone: 10.1.3
Component: sugar-toolkit Version: Development build as of this date
Keywords: Cc:
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Steps to reproduce:

- open activity - change title - close activity directly

If you switch first to another activity it is not triggered. This is the case since new code which was introduced uses the 'focus-out' event. http://bugs.sugarlabs.org/ticket/1948#comment:13

I will think a moment what the best solution is - but I think the simplest is to use Aleksey's patch.

Attachments

0001-Save-title-when-closing-1948.patch (2.0 kB) - added by erikos 4 years ago.
save title when hitting stop button - disconnect the focus-out handler

Change History

Changed 4 years ago by erikos

save title when hitting stop button - disconnect the focus-out handler

Changed 4 years ago by erikos

  • next_action changed from code to review

I tested if the focus-out event is propagated. When hitting stop the focus-out is emitted, though we do save first. I have added now a line that just saves the title when hitting stop. Furthermore the focus-out-event handler is disconnected to not receive events when the activity is deconstructed (can be seen in current code).

Changed 4 years ago by erikos

  • next_action changed from review to package
  • milestone changed from Not Triaged to 10.1.3

Changed 4 years ago by erikos

|TestCase|

- open activity

- change title

- close activity directly

Changed 4 years ago by greenfeld

Tested with various activities and the following test RPMs: sugar-0.84.22-2.fc11.i586.rpm sugar-artwork-0.84.2-2.fc11.i586.rpm sugar-presence-service-0.84.1-2.fc11.noarch.rpm sugar-toolkit-0.84.12-2.fc11.i586.rpm

Attempted to change the title assigned to an activity session and then immediately press the Stop button to exit out of said activity. The title change was remembered in each case.

Changed 4 years ago by erikos

  • next_action changed from package to test in build

Is available in os350.

Changed 4 years ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

Tested that this fix still works in 10.1.3 os351 on both XO-1 and XO-1.5 with various activities.

Note: See TracTickets for help on using tickets.