Title change is not always recognized

[erikos]

Steps to reproduce:

- open activity - change title - close activity directly

If you switch first to another activity it is not triggered. This is the case since new code which was introduced uses the 'focus-out' event. http://bugs.sugarlabs.org/ticket/1948#comment:13

I will think a moment what the best solution is - but I think the simplest is to use Aleksey's patch.

[erikos]

save title when hitting stop button - disconnect the focus-out handler

[erikos]

I tested if the focus-out event is propagated. When hitting stop the focus-out is emitted, though we do save first. I have added now a line that just saves the title when hitting stop. Furthermore the focus-out-event handler is disconnected to not receive events when the activity is deconstructed (can be seen in current code).

[erikos]

|TestCase|

- open activity

- change title

- close activity directly

[greenfeld]

Tested with various activities and the following test RPMs: sugar-0.84.22-2.fc11.i586.rpm sugar-artwork-0.84.2-2.fc11.i586.rpm sugar-presence-service-0.84.1-2.fc11.noarch.rpm sugar-toolkit-0.84.12-2.fc11.i586.rpm

Attempted to change the title assigned to an activity session and then immediately press the Stop button to exit out of said activity. The title change was remembered in each case.

[erikos]

Thanks for testing, pushed as:

http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/0ba47d0e66c0281c8e5c537e0b98c11bdc0a8e3f

[erikos]

Is available in os350.

[greenfeld]

Tested that this fix still works in 10.1.3 os351 on both XO-1 and XO-1.5 with various activities.