Ticket #10365 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Can not save pictures from the olpc library with Browse to Journal

Reported by: erikos Owned by: godiard
Priority: normal Milestone: 10.1.3
Component: browse-activity Version: 1.5/1.0 Software Build os852 aka 10.1.2
Keywords: Cc: godiard
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Steps to reproduce:

- open Browse and go to the images category

- view an image

- right click and use the option 'download image'. Nothing happens.

The code that handles this is here: http://git.sugarlabs.org/projects/browse/repos/mainline/blobs/master/palettes.py#line224

Attachments

Change History

  Changed 4 years ago by godiard

  • next_action changed from diagnose to test in build

  Changed 4 years ago by erikos

Great, I new I have seen that issue already - thanks for the patch.

follow-up: ↓ 6   Changed 4 years ago by martin.langhoff

Is the patch broken for other uri schemes like https, file and ftp?

(Bonus question: what's the point of downloading a file: resource? ;-) -- However in Sugar it's neat "user" trick to get something into the Journal)

follow-up: ↓ 9   Changed 4 years ago by Quozl

  • next_action changed from test in build to package
  • version changed from Development build as of this date to 1.5/1.0 Software Build os852 aka 10.1.2
  • milestone changed from Not Triaged to 10.1.3

Tested patch on 10.1.2, can save pictures from the OLPC Library with Browse, the usual download sequence occurs.

Next step: package into Browse.

  Changed 4 years ago by godiard

  • cc godiard added

in reply to: ↑ 3   Changed 4 years ago by erikos

Replying to martin.langhoff:

Is the patch broken for other uri schemes like https, file and ftp?

No, they work fine. We just do check if the scheme is http before we manipulate the channel's referrer https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIHttpChannel#Attributes

(Bonus question: what's the point of downloading a file: resource? ;-) -- However in Sugar it's neat "user" trick to get something into the Journal)

Right, it is another way of getting something into the Journal :) Btw, the patch does as well fix the FTP case, so it is good to get it in.

  Changed 4 years ago by erikos

  • owner changed from erikos to godiard

Moving this one to Gonzalo, as he takes care of Browse (0.84) now.

  Changed 4 years ago by erikos

Oh, forgot a quick comment about the patch. Please Mark the bug in the comment SL #NUMBER so we know that we refer to the Sugar Labs tracker here.

in reply to: ↑ 4   Changed 4 years ago by erikos

Replying to Quozl:

Tested patch on 10.1.2, can save pictures from the OLPC Library with Browse, the usual download sequence occurs.

Thanks for testing. I did test the FTP case as working now fine with this patch.

Next step: package into Browse.

Gonzalo will take care of it.

  Changed 4 years ago by erikos

This one is ready to be pushed to the 0.84 branch.

  Changed 4 years ago by godiard

Pushed to git

  Changed 3 years ago by erikos

  • next_action changed from package to test in build

Will be in 353.

  Changed 3 years ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

I was able to save images to the Journal from both Browse as well as from HTTP-based websites in 10.1.3 os353.

Note: See TracTickets for help on using tickets.