Ticket #10372 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Activities list view crashes in Arabic

Reported by: cjb Owned by: erikos
Priority: normal Milestone: 10.1.3
Component: sugar-toolkit Version: 1.5/1.0 Software Build os852 aka 10.1.2
Keywords: Cc: greenfeld
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking: #6808

Description

Hi,

On Arabic machines (LANG=ar_SY.UTF-8) the activities list view is always empty. shell.log contains: 

  File "/usr/lib/python2.6/site-packages/sugar/util.py", line 251, in timestamp_to_elapsed_string
    elapsed_units) % elapsed_units
TypeError: not all arguments converted during string formatting

Perhaps a translation is missing?

Attachments

0001-If-the-string-does-not-contain-a-conversion-specifie.patch (1.5 kB) - added by erikos 3 years ago.
Patch against 0.84

Change History

Changed 3 years ago by erikos

  • component changed from sugar to sugar-toolkit

We have that issue as well in master so I filed as well SL #2354.

And it effects the Activities list and the Journal.

We fail here, since the translation pulled does not have a '%d'. Looking at pootle there are strings that look wrong. I mailed the localization list for feedback.

On a second note, we might need to make the code more robust. I will have a look at a similar issue that has been reported in python.

Changed 3 years ago by erikos

  • owner changed from cjb to erikos
  • next_action changed from diagnose to package
  • milestone changed from Not Triaged to 10.1.3

Sam, can you please test that rpm with (LANG=ar_SY.UTF-8): http://dev.laptop.org/~erikos/F11_rpms/sugar-toolkit-0.84.12-2.fc11.i586.rpm

The activities list view should be displayed correctly. Furthermore the Journal main view should display correctly as well.

Changed 3 years ago by erikos

Patch against 0.84

Changed 3 years ago by erikos

  • cc greenfeld added; erikos removed

Changed 3 years ago by erikos

  • next_action changed from package to test in build

Pushed as: http://git.sugarlabs.org/projects/sugar-toolkit/repos/mainline/commits/2bb16e651e80d6caa0bbcf90608b1cd53e5809f1

Is available in os350.

Changed 3 years ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

Verified in 10.1.3 os351 that the activities list and the journal view do not crash in Arabic.

Changed 2 years ago by cjl

  • blocking 6808 added
Note: See TracTickets for help on using tickets.