Ticket #10399 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

XO-1 can't wake on lid close

Reported by: pgf Owned by: pgf
Priority: normal Milestone: 10.1.3
Component: kernel Version: not specified
Keywords: Cc:
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

when the laptop is in open, in idle suspend, and the lid is closed, the backlight will stay on until the system wakes for some other reason.

the attached patch adds a sysfs node (matching the one implemented for XO-1.5) which lets one enable wake-on-close.

Attachments

wake_on_close.patch (3.1 kB) - added by pgf 4 years ago.

Change History

Changed 4 years ago by pgf

Changed 4 years ago by pgf

(i should add that the patch is untested.)

Changed 3 years ago by pgf

note: initial brief testing of "disable_lid.patch" showed it to be insufficient.

Changed 3 years ago by martin.langhoff

  • next_action changed from never set to code
  • component changed from not assigned to kernel

Triaging for 10.1.3 .

Paul, do you think you'll have a more complete fix sometime soon, considering 1.75 bringup workload? Is the (insufficient) patch above on the F11 OLPC kernel?

Changed 3 years ago by pgf

i'd like to look at this again, but it won't be for at least another week, probably more, and my initial testing gave me doubts as to a final fix. no changes have yet gone into git.

if someone else with kernel and geode gpio chops would like to give it a try, i'm happy to cheer from the sidelines.

Changed 3 years ago by martin.langhoff

  • milestone changed from 10.1.3 to Future Release

Changed 3 years ago by pgf

  • next_action changed from code to add to build
  • milestone changed from Future Release to 10.1.3

lid wakeups on XO-1 are now implemented via new /sys/power/wake-on-lid node, which can take the values "always", "open", "close", or "never". implemented in 1edf204d38125e46ae9e45c641f9b7877eec2a5c.

Changed 3 years ago by martin.langhoff

So I take it that combined with powerd-30 we're all sorted? Excellent!

Changed 3 years ago by erikos

http://dev.laptop.org/git/olpc-2.6/commit/?h=olpc-2.6.31&id=1edf204d38125e46ae9e45c641f9b7877eec2a5c

I guess that is the one for #10398 and this ticket. The new powerd is already in the repo, Paul are you doing as well the kernel packages? Or who do we need to ping here?

Changed 3 years ago by erikos

  • next_action changed from add to build to test in build

Is in 354.

Changed 3 years ago by pgf

recordkeeping: #8137 and #7536 are closed as dups of this bug.

Changed 3 years ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

XO-1s no longer wake up on lid open by default in 10.1.3 os354, and turn off the backlight when closed.

The sysfs field is there and can report & be set with the above values. However in practical usage any directly made user changes get reset by powerd to match its' configuration needs on set events.

Note: See TracTickets for help on using tickets.