Opened 4 years ago

Closed 4 years ago

#10412 closed defect (fixed)

Ad-hoc networking icons appear in network search results when connect/disconnect requested

Reported by: greenfeld Owned by: erikos
Priority: low Milestone: 10.1.3
Component: sugar Version: Development build as of this date
Keywords: Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

This is a minor fork from testing issue #9845 for planning purposes, as this sub-issue may or may not get fixed this release.

It is possible for the new Mayan-numeral style Ad-hoc icons to appear in the network view's search results in a non-grayed out manner, even if they do not match the search results.

Reproduction:

  1. Switch to Sugar's network view
  2. In the search box in the top bar, start typing the name of an Access point you have access to.
  3. Hover over the access point (which should be colored), and choose to "connect" or "disconnect" to said AP.

Expected: Only the items which match the search box's entry should remain colored.
Actual: The items which match the search box's entry, as well as the three Ad-hoc channel network icons are now fully colored and not grayed out, even though the Ad-hoc channel names given likely do not match your search string.

Attachments (1)

0001-Sugar-Ad-hoc-icons-show-in-search-results-when-conne.patch (2.2 KB) - added by erikos 4 years ago.
Patch for 0.84

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by erikos

Hmm, for me it works as expected. If I type in any character(s) that are in the string 'Ad-hoc network 1' it stays colored. Otherwise it is grayed out, like with any other AP. Sam, any specific character that might break?

comment:2 follow-up: Changed 4 years ago by greenfeld

Try typing the name of a different network; not one of the Ad-hoc ones. Then choose to connect or disconnect to said network to see the Ad-hoc items become colored.

comment:3 in reply to: ↑ 2 Changed 4 years ago by erikos

Replying to greenfeld:

Try typing the name of a different network; not one of the Ad-hoc ones. Then choose to connect or disconnect to said network to see the Ad-hoc items become colored.

Ok, reproduced now.

comment:4 Changed 4 years ago by erikos

  • Action Needed changed from diagnose to code
  • Component changed from not assigned to sugar
  • Owner set to erikos
  • Version changed from not specified to Development build as of this date

comment:5 Changed 4 years ago by erikos

  • Action Needed changed from code to review

Ok, I just created a patch for master that fixes the issue.

http://lists.sugarlabs.org/archive/sugar-devel/2010-November/028526.html

Backporting to 0.84 is trivial.

Changed 4 years ago by erikos

Patch for 0.84

comment:6 Changed 4 years ago by erikos

  • Action Needed changed from review to package

comment:7 Changed 4 years ago by erikos

  • Action Needed changed from package to test in build

Is in 353.

comment:8 Changed 4 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

Tested that the Ad-hoc Networking icons appear to gray out and appear in color appropriately in 10.1.3 os353.

Note: See TracTickets for help on using tickets.