Opened 4 years ago

Closed 4 years ago

#10488 closed defect (fixed)

Color chooser does not always work when giving color to selected text

Reported by: erikos Owned by: godiard
Priority: normal Milestone: 10.1.3
Component: sugar-toolkit Version: Development build as of this date
Keywords: Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

Steps to reproduce:

  • write some text
  • select text
  • change color
  • dismiss palette (clicking on the canvas)

There seem to be a timeout. When you leave the palette open for a while the color change seem to happen. When you go away immediately it does not. I remember we had already tickets about it on sugarlabs... Benzea might be a good person as well to talk to about it.

Attachments (1)

0001-fix-OLPC-10488-Color-chooser-does-not-always-work-wh.patch (1.2 KB) - added by godiard 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 4 years ago by godiard

  • Action Needed changed from diagnose to review
  • Component changed from write-activity (abiword) to sugar-toolkit

This problem can be tested in Write but is more evident in Paint.

Change Component to sugar-toolkit

comment:3 Changed 4 years ago by erikos

  • Action Needed changed from review to code
self._text_color = ColorToolButton()
        self._text_color_id = self._text_color.connect('notify::color', self._text_color_cb)
def _text_color_cb(self, button, pspec):
        newcolor = self._text_color.get_color()

Seem to work here fine (based on the answers from Benjamin). (Change is in Write)

comment:4 Changed 4 years ago by godiard

  • Action Needed changed from code to test in build
  • Component changed from sugar-toolkit to write-activity (abiword)

Can be tested in Write 63.4 and Paint 30

comment:5 Changed 4 years ago by godiard

  • Component changed from write-activity (abiword) to sugar-toolkit

Test in os358

comment:6 Changed 4 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

I setup an XO-1 10.1.2 system to look at the bug occurring first so I could figure out what the fix was. It happens in Write when you try to change text colors quickly with the "new" color selector which does not default to forcing you to use a color wheel by default.

I then tested on an XO-1 and 1.5 with 10.1.3 os358 to verify that the issue was fixed. You may not see the color change immediately if you click out of the color changer dropdown in a way which keeps the text to be color changed highlighted, but will see the change after the highlight is removed from said text.

Note: See TracTickets for help on using tickets.