Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#10671 closed defect (fixed)

Neighborhood view is sometimes greyed out or owner buddy is missing

Reported by: erikos Owned by: erikos
Priority: blocker Milestone: 11.2.0-final
Component: sugar Version: Development build as of this date
Keywords: collaboration Cc: pbrobinson
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

Sam does not know what caused the issue, attached are the logs.

Attachments (1)

grey_Neighborhood.log (156.6 KB) - added by erikos 4 years ago.
Grey neighorhood view

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by erikos

Grey neighorhood view

comment:1 Changed 4 years ago by erikos

  • Keywords collaboration added

comment:2 Changed 4 years ago by erikos

  • Action Needed changed from diagnose to code

When reorganizing the network view we try to move ourself on the grid. Which should not happen as we are always in the center. I printed out the nick name property of the BuddyIcon when this happens and it is the owner's nick.

Traceback (most recent call last):
2032	  File "/usr/lib/python2.7/site-packages/jarabe/desktop/meshbox.py", line 458, in do_size_allocate
2033	    self._layout.move(self._owner_icon, x, y)
2034	  File "/usr/lib/python2.7/site-packages/jarabe/desktop/spreadlayout.py", line 50, in move
2035	    self._grid.move(child, x / _CELL_SIZE, y / _CELL_SIZE, locked=True)
2036	  File "/usr/lib/python2.7/site-packages/jarabe/desktop/grid.py", line 86, in move
2037	    self.remove_weight(self._child_rects[child])
2038	KeyError: <BuddyIcon object at 0x8f71964 (CanvasIcon at 0x9085188)>

comment:3 Changed 4 years ago by erikos

  • Priority changed from normal to high

comment:4 Changed 4 years ago by pbrobinson

  • Cc pbrobinson added

There is a possible patch in this sugar ticket, not sure if its of help.
http://bugs.sugarlabs.org/ticket/2483

comment:5 Changed 4 years ago by erikos

  • Keywords blocker? added

comment:6 Changed 4 years ago by dsd

  • Keywords blocker? removed
  • Milestone changed from 11.2.0-M4 to 11.2.0-final
  • Priority changed from high to blocker

comment:7 Changed 4 years ago by erikos

  • Summary changed from Neighborhood view is greyed out to Neighborhood view is sometimes greyed out or owner buddy is missing

same name as upstream ticket.

comment:8 Changed 3 years ago by erikos

  • Action Needed changed from code to review

This one should be fixed by 10675#comment:6. Reasoning in http://lists.sugarlabs.org/archive/sugar-devel/2011-June/032060.html.

Another double check could be the following, but I don't think we need this anymore:

diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py
index 3d1e52a..a949f84 100644
--- a/src/jarabe/desktop/meshbox.py
+++ b/src/jarabe/desktop/meshbox.py
@@ -474,8 +474,9 @@ class MeshBox(gtk.VBox):
         self._remove_activity(activity_model)
 
     def _add_buddy(self, buddy_model):
-        buddy_model.connect('notify::current-activity',
-                            self.__buddy_notify_current_activity_cb)
+        if not buddy_model.is_owner():
+            buddy_model.connect('notify::current-activity',
+                                self.__buddy_notify_current_activity_cb)
         if buddy_model.props.current_activity is not None:
             return
         icon = BuddyIcon(buddy_model)

comment:9 Changed 3 years ago by erikos

  • Action Needed changed from review to test in build

Just watch out if you see a greyed out neighborhood view.

comment:10 Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to no action

I have not seen a greyed-out network view in the past two weeks while testing or using collaboration, so this probably can be closed safely.

comment:11 Changed 3 years ago by greenfeld

  • Resolution set to fixed
  • Status changed from new to closed

comment:12 follow-up: Changed 3 years ago by pbrobinson

Is this change upstream in Sugar or is it still only in the patched OLPC release?

comment:13 in reply to: ↑ 12 Changed 3 years ago by erikos

Replying to pbrobinson:

Is this change upstream in Sugar or is it still only in the patched OLPC release?

For now only in the OLPC release. I am awaiting the final ack on the review of #10675.

Note: See TracTickets for help on using tickets.