Opened 4 years ago

Closed 3 years ago

#10676 closed defect (fixed)

Shared activities displayed with activity name, not instance/journal name in the sugar network view

Reported by: greenfeld Owned by: erikos
Priority: high Milestone: 11.3.0
Component: sugar Version: Development build as of this date
Keywords: collaboration Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

Shared activities historically have been displayed with the name a user has assigned for the shared instance (such as "Chat Activity", "My Chat", etc.), which eventually gets copied to the journal in Sugar's Network View.

Right now in 11.2.0 os7 activities are shown in the Network View with only the core activity name shown ("Chat", "Labyrinth", etc.). The 10.1.3 release shows the instance name that can be changed by children/end-users instead.

We need to decide which way to go for the 11.2.0 release.

Attachments (1)

activity-title.png (5.8 KB) - added by erikos 4 years ago.
Example of activity name and session title in the palette

Download all attachments as: .zip

Change History (19)

comment:1 Changed 4 years ago by erikos

  • Milestone changed from Not Triaged to 11.2.0-M4
  • Version changed from Development source as of this date to Development build as of this date

comment:2 Changed 4 years ago by erikos

  • Keywords collaboration added

comment:3 Changed 4 years ago by erikos

  • Priority changed from normal to high

comment:4 Changed 4 years ago by erikos

  • Action Needed changed from diagnose to code
diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py
index 3d1e52a..00fd949 100644
--- a/src/jarabe/desktop/meshbox.py
+++ b/src/jarabe/desktop/meshbox.py
@@ -94,7 +94,7 @@ class ActivityView(hippo.CanvasBox):
         return icon
 
     def _create_palette(self):
-        p_text = glib.markup_escape_text(self._model.bundle.get_name())
+        p_text = glib.markup_escape_text(self._model.get_name())
         p_icon = Icon(file=self._model.bundle.get_icon(),
                       xo_color=self._model.get_color())
         p_icon.props.icon_size = gtk.ICON_SIZE_LARGE_TOOLBAR

Actually a simple patch. This does restore the previous behavior.

comment:5 Changed 4 years ago by erikos

diff --git a/src/jarabe/desktop/meshbox.py b/src/jarabe/desktop/meshbox.py
index 3d1e52a..83740d0 100644
--- a/src/jarabe/desktop/meshbox.py
+++ b/src/jarabe/desktop/meshbox.py
@@ -94,12 +94,14 @@ class ActivityView(hippo.CanvasBox):
         return icon
 
     def _create_palette(self):
-        p_text = glib.markup_escape_text(self._model.bundle.get_name())
+        primary_text = glib.markup_escape_text(self._model.bundle.get_name())
+        secondary_text = glib.markup_escape_text(self._model.get_name())
         p_icon = Icon(file=self._model.bundle.get_icon(),
                       xo_color=self._model.get_color())
         p_icon.props.icon_size = gtk.ICON_SIZE_LARGE_TOOLBAR
         p = palette.Palette(None,
-                            primary_text=p_text,
+                            primary_text=primary_text,
+                            secondary_text=secondary_text,
                             icon=p_icon)
 
         private = self._model.props.private

Like in the activity tray in the frame we should maybe display the activity name AND the title of the session.

Changed 4 years ago by erikos

Example of activity name and session title in the palette

comment:6 Changed 4 years ago by erikos

  • Action Needed changed from code to review

comment:8 Changed 3 years ago by erikos

  • Action Needed changed from review to package

|TestCase|

  • on A open Memorize, name the instance and share it
  • on A and B the palette text in the neighborhood view should display the activity name AND the title of the session. In Spanish: "Memorizar" "Vacaciones" In German: "Merken" "Ferien"

comment:9 Changed 3 years ago by erikos

  • Action Needed changed from package to add to build

One thing I just noted is: On B if you open the activity the title does not have the 'custom title' (activity instance title) from A for the activity neither the activity frame palette have it. I will have a look at it. There is as well http://bugs.sugarlabs.org/ticket/1474 which I marked for having a look at it.

comment:10 Changed 3 years ago by dsd

  • Action Needed changed from add to build to test in build

test in 11.2.0 build 21

comment:11 Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

In 11.2.0 build 22 we show shared activity sessions by their (localized) Activity name and the (non-translated) current user-supplied session title.

Tested with both Salut and Gabble.

comment:12 Changed 3 years ago by erikos

  • Action Needed changed from no action to review
  • Resolution fixed deleted
  • Status changed from closed to reopened

I reopen this one because it is still under review.

comment:13 Changed 3 years ago by erikos

In the follow-up patch I made the palette on demand: http://lists.sugarlabs.org/archive/sugar-devel/2011-July/032188.html

comment:14 Changed 3 years ago by erikos

|TestCase|

  • A opens activity set the name to 'X' and shares it

---> on his nb view the activity palette shows 'X' as the secondary title

  • A changes the name activity name to 'Y'

---> on his nb view the activity palette shows 'Y' as the secondary title

comment:15 Changed 3 years ago by erikos

  • Action Needed changed from review to package
  • Milestone changed from 11.2.0-M4 to 11.3.0

comment:16 Changed 3 years ago by erikos

  • Action Needed changed from package to add to build

in sugar-0.92.4-1.fc14.olpc.noarch.rpm (in my public repo)

|TestCase|

  • open an activity (e.g. Memorize)
  • change the title in the activity
  • go to the nb view and open the palette of the shared activity

---> the palette should contain the activity name and the instance/journal name as secondary text

(be aware of #11087 when testing)

comment:17 Changed 3 years ago by dsd

  • Action Needed changed from add to build to test in build

test in 11.3.0 build 1

comment:18 Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in 11.3.0 os2.

Note: See TracTickets for help on using tickets.