Opened 4 years ago

Last modified 3 years ago

#10749 new defect

salut: mission control account information is not updated when changing the nick name

Reported by: erikos Owned by: erikos
Priority: high Milestone: 11.3.0
Component: sugar Version: Development build as of this date
Keywords: collaboration Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: diagnose
Verified: no

Description

Steps to reproduce:

  • log into your machine (check the account information in $HOME/.mission-control/)
  • change the nick name (in the CP), restart Sugar
  • hover over your XO-icon on your machine (the nick name should be updated), hover over the XO-icon on another machine, the name shown will be the old one, check the account information in $HOME/.mission-control/

Change History (18)

comment:1 Changed 4 years ago by erikos

  • Summary changed from mission control account information is not updated when changing the nick name to salut: mission control account information is not updated when changing the nick name

Only the salut account does not seem to get updated, the gabble account does.

comment:2 Changed 4 years ago by erikos

  • Action Needed changed from code to review

comment:3 Changed 4 years ago by erikos

  • Action Needed changed from review to package

comment:4 Changed 4 years ago by erikos

  • Action Needed changed from package to add to build

|TestCase|

  • make sure machine A and B see each other when using salut (link local connection)
  • change the nick name on machine A
  • the change should be propagated (palette in the neighborhood view and group view on machine B)

comment:5 Changed 4 years ago by dsd

  • Action Needed changed from add to build to test in build

test in 11.2.0-17

comment:6 Changed 3 years ago by greenfeld

I tried this in 11.2.0-19, but the new name only appeared in the neighborhood view and not the group view, even after restarting the monitoring XO. Is this by design?

comment:7 Changed 3 years ago by erikos

  • Priority changed from normal to high

comment:8 Changed 3 years ago by erikos

  • Action Needed changed from test in build to diagnose

comment:9 Changed 3 years ago by erikos

  • Action Needed changed from diagnose to code
diff --git a/src/jarabe/model/friends.py b/src/jarabe/model/friends.py
index 7f50c1e..7605af1 100644
--- a/src/jarabe/model/friends.py
+++ b/src/jarabe/model/friends.py
@@ -61,6 +61,8 @@ class FriendBuddyModel(BuddyModel):
         self.notify('color')
         self.notify('present')
 
+        if buddy.nick != self.nick:
+            self.nick = buddy.nick
         if buddy.contact_id != self.contact_id:
             self.contact_id = buddy.contact_id
         if buddy.account != self.account:

Looks like the above does it. Will test a bit more.

comment:10 Changed 3 years ago by erikos

  • Action Needed changed from code to review

Sent for review: http://lists.sugarlabs.org/archive/sugar-devel/2011-June/032066.html

|TestCase|

  • make sure machine A and B see each other when using salut (link local connection)
  • change the nick name on machine A
  • the change should be propagated (palette in the neighborhood view and group view (friends view on machine B)

comment:11 Changed 3 years ago by erikos

  • Action Needed changed from review to test in build

comment:12 Changed 3 years ago by erikos

sugar-0.92.2.9.gb092121-1.fc14.olpc.noarch.rpm

comment:14 Changed 3 years ago by godiard

The name is changed (but not the color) Must we create another ticket?

If this ticket is only about the name, can be closed.

Tested in 871

comment:15 Changed 3 years ago by erikos

So what I see is the following:

  • A and B connect to the same network
  • A makes B a friend

---> B appears in the group view

  • B changes the nick and the color in the CP and gets an alert to restart Sugar

---> on A's group view the nick of B changes but not the color

  • B does restart Sugar

---> on A's group and nb view B is still present (B is not yet in the same network though)

  • B connects to the same network

---> A's nb view and group view has the updated color

Yes, we should open another ticket for that because it has nothing to do with the Salut mission control information.

comment:16 Changed 3 years ago by erikos

The underlying issue in the scenario described above is: #10450 I just verified that we do not get any leave signal.

So, the test from Gonzalo counts as a 'is working one' for this ticket to me.

comment:17 Changed 3 years ago by dsd

This doesn't work reliably for me. A=XO-1.5 and B=XO-1, both on 11.2.0 candidate build 871, communicating over ad-hoc.

Here is a test case that shows the problem clearer:

  • A and B join the same network, they are not friends
  • B looks at neighborhood view, observes A
  • A goes to "About Me" settings dialog, changes name to "one", waits for a few seconds. Sugar then warns "changes require restart". A does not do anything here - do not restart.
  • B's neighborhood view has already updated A's name, correctly showing "one"
  • Back on A, still with the name dialog open, change name to "two". Again, do not restart, Observe quick name change on B.

Continue this test, running through the numbers. Usually fails for me before I reach five. In the failure case, B's neighbourhood view continues to show an old name, even if I wait a minute or so, and even if I restart A's Sugar (as requested) and reconnect A to the network.

comment:18 Changed 3 years ago by dsd

  • Action Needed changed from test in build to diagnose
Note: See TracTickets for help on using tickets.