salut: mission control account information is not updated when changing the nick name

[erikos]

Steps to reproduce:

- log into your machine (check the account information in $HOME/.mission-control/)

- change the nick name (in the CP), restart Sugar

- hover over your XO-icon on your machine (the nick name should be updated), hover over the XO-icon on another machine, the name shown will be the old one, check the account information in $HOME/.mission-control/

[erikos]

Only the salut account does not seem to get updated, the gabble account does.

[erikos]

http://lists.sugarlabs.org/archive/sugar-devel/2011-March/030439.html

[erikos]

Pushed to master and sucrose-0.92: http://git.sugarlabs.org/sugar/mainline/commit/e385144b67404de98ddcd74b99e4745bbe0d7834

[erikos]

|TestCase|

- make sure machine A and B see each other when using salut (link local connection)

- change the nick name on machine A

- the change should be propagated (palette in the neighborhood view and group view on machine B)

[dsd]

test in 11.2.0-17

[greenfeld]

I tried this in 11.2.0-19, but the new name only appeared in the neighborhood view and not the group view, even after restarting the monitoring XO. Is this by design?

[erikos]

diff --git a/src/jarabe/model/friends.py b/src/jarabe/model/friends.py
index 7f50c1e..7605af1 100644
--- a/src/jarabe/model/friends.py
+++ b/src/jarabe/model/friends.py
@@ -61,6 +61,8 @@ class FriendBuddyModel(BuddyModel):
         self.notify('color')
         self.notify('present')
 
+        if buddy.nick != self.nick:
+            self.nick = buddy.nick
         if buddy.contact_id != self.contact_id:
             self.contact_id = buddy.contact_id
         if buddy.account != self.account:

Looks like the above does it. Will test a bit more.

[erikos]

Sent for review: http://lists.sugarlabs.org/archive/sugar-devel/2011-June/032066.html

|TestCase|

- make sure machine A and B see each other when using salut (link local connection)

- change the nick name on machine A

- the change should be propagated (palette in the neighborhood view and group view (friends view on machine B)

[erikos]

sugar-0.92.2.9.gb092121-1.fc14.olpc.noarch.rpm

[erikos]

Pushed upstream: http://git.sugarlabs.org/sugar/mainline/commit/ef96e7033a81922e6d5c7e6b57952a09469a585e

[godiard]

The name is changed (but not the color) Must we create another ticket?

If this ticket is only about the name, can be closed.

Tested in 871

[erikos]

So what I see is the following:

- A and B connect to the same network

- A makes B a friend

---> B appears in the group view

- B changes the nick and the color in the CP and gets an alert to restart Sugar

---> on A's group view the nick of B changes but not the color

- B does restart Sugar

---> on A's group and nb view B is still present (B is not yet in the same network though)

- B connects to the same network

---> A's nb view and group view has the updated color

Yes, we should open another ticket for that because it has nothing to do with the Salut mission control information.

[erikos]

The underlying issue in the scenario described above is: #10450 I just verified that we do not get any leave signal.

So, the test from Gonzalo counts as a 'is working one' for this ticket to me.

[dsd]

This doesn't work reliably for me. A=XO-1.5 and B=XO-1, both on 11.2.0 candidate build 871, communicating over ad-hoc.

Here is a test case that shows the problem clearer:

• A and B join the same network, they are not friends
• B looks at neighborhood view, observes A
• A goes to "About Me" settings dialog, changes name to "one", waits for a few seconds. Sugar then warns "changes require restart". A does not do anything here - do not restart.
• B's neighborhood view has already updated A's name, correctly showing "one"
• Back on A, still with the name dialog open, change name to "two". Again, do not restart, Observe quick name change on B.

Continue this test, running through the numbers. Usually fails for me before I reach five. In the failure case, B's neighbourhood view continues to show an old name, even if I wait a minute or so, and even if I restart A's Sugar (as requested) and reconnect A to the network.