gabble: nick name is set to jabber_account_id

[erikos]

no concrete steps yet to reproduce it

[erikos]

I am seeing it quite regularly when using gabble, the nick name is the same than the contact_id, e.g. 'c72019147aed6de8731769a126c2931a8a9ecfeb@…ylane'. This is quite serious as it affects all the occasions of the nick, for example the nick in the palette of the buddy in the neighborhood view, the buddy nick in the frame etc.

We use the 'alias' to determine the nickname. The code is similar to the one in the presence service in 0.84, though I have not seen an occasion of a wrong nick on my 0.84 machine. I will investigate if they do something smart in the old PS code.

[erikos]

In 10.1.3 we do as well set the alias when a connection has been established. I did commented that out and the alias of that machine was wrong as well on other machines. I will see if calling 'SetAliases' when the connection is established in the same way in 11.2.0 will solve the issue from above.

[erikos]

Actually, we do seem to get the correct nick information but we did not update the buddy because of checking for a wrong property key:

diff --git a/src/jarabe/model/neighborhood.py b/src/jarabe/model/neighborhood.py
index 7004283..828cb14 100644
--- a/src/jarabe/model/neighborhood.py
+++ b/src/jarabe/model/neighborhood.py
@@ -929,8 +929,9 @@ class Neighborhood(gobject.GObject):
         if 'key' in properties:
             buddy.props.key = properties['key']
 
-        if 'nick' in properties:
-            buddy.props.nick = properties['nick']
+        nick_key = CONNECTION_INTERFACE_ALIASING + '/alias'
+        if nick_key in properties:
+            buddy.props.nick = properties[nick_key]
 
         if is_new:
             self.emit('buddy-added', buddy)

I checked that in all the cases (alias-change or when we do get the buddy information in various ways) the key is "CONNECTION_INTERFACE_ALIASING + '/alias'".

[erikos]

Is upstream, pushed as:

http://git.sugarlabs.org/sugar/mainline/commit/5598b9f81a8fcc6ed73caaa338a2366fd7422ed9

http://git.sugarlabs.org/sugar/mainline/commit/9499044b9d9d680fe283890c2e15c68bfee1c572

[erikos]

in sugar-0.92.4-1.fc14.olpc.noarch.rpm (in my public repo)

|TestCase|

- connect more than one machine to a jabber server

- check the nick names in the buddy palettes in the neighborhood view, the friends tray and the Journal (file transfer palette option)

[dsd]

test in 11.3.0 build 1

[greenfeld]

Attached 3 XOs with 11.3.0-1 to a school server. Verified all three saw each other by name in the network view, Friends view, and when transferring a Journal entry between two XOs.

[jvonau]

Observed same problem using 11.3-os3, fix was to delete ~/.mission=control/accounts/accounts.cfg and restart sugar, then the NICK was displayed correctly using jabber.sugarlabs.org or a local schoolserver.

[jvonau]

Ok, let me clarify myself, using an olpc based schoolserver, the nick is displayed in neighbourhood view. Using a prosody based jabber server(jabber.sugarlabs.org or sugarserver-on-XO1) I get the long jabber_account_id.

[erikos]

Replying to jvonau:

Ok, let me clarify myself, using an olpc based schoolserver, the nick is displayed in neighbourhood view. Using a prosody based jabber server(jabber.sugarlabs.org or sugarserver-on-XO1) I get the long jabber_account_id.

Ok, thanks for clarifying. Please check with dx people then.

[erikos]

I am seeing this again in os6, using my vanilla olpc school server.

[leeming]

Using XO-1s with release 11.3.0 (build 883 / Sugar 0.94.1) registered on an XS server v0.6 I am seeing this reproducibly. I.e. on a default installation with no customization. The XOs will display the nickname when connected to the mesh, but when connected to the server the long name (i.e. jabber account ID as I understand from the above)

[sascha_silbe]

See also the corresponding upstream ticket SL#2355. Please continue discussion there as it clearly affects upstream Sugar, not just OLPC OS / XS.