Opened 3 years ago

Closed 3 years ago

#10867 closed enhancement (fixed)

Jukebox activity has old toolbar

Reported by: godiard Owned by: godiard
Priority: normal Milestone: 12.1.0
Component: other-activity Version: not specified
Keywords: Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

All the activities in our image must have the new toolbar.

Change History (12)

comment:1 Changed 3 years ago by RafaelOrtiz

Sebastian Silva has a merge request for this issue

http://git.sugarlabs.org/jukebox/mainline/merge_requests/2

and has worked with the dev to have it on mainline.

comment:2 Changed 3 years ago by godiard

  • Component changed from not assigned to other-activity

comment:3 Changed 3 years ago by dsd

  • Milestone changed from 11.2.0-M3 to Future Release
  • Type changed from defect to enhancement

Not ready in time for 11.2.0; very welcome in a future development window.

comment:4 Changed 3 years ago by godiard

A patch is already sent to the maintainer. (In this case two different patches)

comment:5 Changed 3 years ago by godiard

  • Action Needed changed from code to add to build

Version 22 include this change

comment:6 Changed 3 years ago by godiard

  • Milestone changed from Future Release to 11.3.0

comment:7 Changed 3 years ago by dsd

  • Action Needed changed from add to build to test in build

test in 11.3.0 build 2

comment:8 follow-up: Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to diagnose

I cannot click on the music notes (activity symbol) in the menu to get to the submenu to name the current instance of the activity.

Given no activity does this I presume this is broken.

{Also of note is we have the eye/view icon with fullscreen as the only other sub-menu/sub-option, which is reasonable but also semi-strange.)

comment:9 in reply to: ↑ 8 Changed 3 years ago by godiard

Replying to greenfeld:

I cannot click on the music notes (activity symbol) in the menu to get to the submenu to name the current instance of the activity.

Given no activity does this I presume this is broken.

No. The activity button does not have a subtoolbar, becuase: a) do not save in the journal, then change the name does not have sense, and b) do not support collaboration.

{Also of note is we have the eye/view icon with fullscreen as the only other sub-menu/sub-option, which is reasonable but also semi-strange.)

This subtoolbar will have a button to show/hide the list of media.

When the list of media will be implemented, the activity will save a session file in the journal, then will have sense show the activity subtoolbar.

comment:10 Changed 3 years ago by godiard

  • Action Needed changed from diagnose to add to build
  • Milestone changed from 11.3.0 to 12.1.0

Check again in Jukebox 24.

comment:11 Changed 3 years ago by dsd

  • Action Needed changed from add to build to test in build

Test in 12.1.0 build 5

comment:12 Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

Jukebox-24 uses the new-style toolbars in 12.1.0 build 6.

Note: See TracTickets for help on using tickets.