Opened 4 years ago

Closed 3 years ago

#10965 closed defect (fixed)

When connected to school server and using gabble buddy is drawn twice in home view

Reported by: erikos Owned by: erikos
Priority: high Milestone: 11.2.0-final
Component: sugar Version: Development build as of this date
Keywords: collaboration Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: yes

Description

  • connect to a school server (gabble is running)
  • in the neighborhood view your buddy is shown twice and other buddies one time
  • this is as well true after restarting Sugar

Change History (9)

comment:1 Changed 4 years ago by erikos

  • Keywords collaboration added
  • Verified set

comment:2 Changed 4 years ago by dsd

this might be related to the ticket where we were trying to remove/delete our own buddy causing the neighborhood view to break?

comment:3 Changed 4 years ago by erikos

  • Action Needed changed from diagnose to code

When we get the members when establishing the connection in gabble we often get as well ourself and hence add ourself as a buddy. We do handle ourself separately, though.

http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/model/neighborhood.py#line554

We should check here for the following:

            if handle == self._self_handle:
                logging.debug('_Account.__get_contact_attributes_cb, do not add ourself %r', handle)
                continue

@dsd, yes this very likely triggers #10671.

comment:4 Changed 3 years ago by erikos

  • Action Needed changed from code to review

comment:5 Changed 3 years ago by erikos

This does not happen all the time, but quite often. As jabber.sugarlabs.org is very noisy atm it is best to test this with a local schoolserver.

comment:6 Changed 3 years ago by erikos

You might see #10750 when testing this.

comment:7 Changed 3 years ago by erikos

  • Action Needed changed from review to test in build

sugar-0.92.2.9.gb092121-1.fc14.olpc.noarch.rpm, build 871

comment:9 Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

Registered two XOs to a schoolserver and verified this does not seem to be a problem with 11.2.0 os872.

Note: See TracTickets for help on using tickets.