Ticket #11095 (closed enhancement: fixed)

Opened 3 years ago

Last modified 2 years ago

Lid switch OFW power off should be consistent across XO versions

Reported by: greenfeld Owned by: greenfeld
Priority: normal Milestone:
Component: ofw - open firmware Version:
Keywords: Cc:
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Boot an unlocked XO and break into Open Firmware. Then close the XO fully without turning it off.

An XO-1.5 with Q3B14 will shut itself off after 8 seconds since it detects the lid switch is activated (unless you open it up in time, or enter "lid-off" to disable the feature). An XO-1 with Q2B45 does not turn off, and an XO-1.75 B1 with Q4B05 does not turn off.

If we are not concerned about stuck lid switches then perhaps we should be consistent about this across all product versions.

Change History

Changed 3 years ago by Quozl

The risks associated with stuck lid switches are entirely different across product versions, so consistency is not required.

Changed 3 years ago by greenfeld

But we are consistent across platforms (except for the XO-1.75, which currently cannot suspend) in suspending the XO when it is closed in Linux, correct?

If so then perhaps we should make OFW consistent with powerd's default behavior.

Changed 3 years ago by Quozl

I don't know about Linux, sorry. I've not checked for consistency there. We failed consistency in power management because there were differences or difficulties, but I don't recall the details. Feel free to test again and raise another ticket.

I don't think OpenFirmware needs to be consistent with powerd, since the OpenFirmware ok prompt is not expected to be used frequently by the end-user, and there is no need for it in the current thermal configuration. That's my opinion. Others welcome.

Changed 3 years ago by wmb@…

  • next_action changed from never set to test in release

Fixed by svn 2573. The fix will appear in q4b11.

Changed 3 years ago by wmb@…

  • owner changed from wmb@… to greenfeld

Changed 3 years ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in release to no action
  • resolution set to fixed

We now detect the lid switch and power off an XO-1.75 in Q4B11.

Changed 2 years ago by Quozl

  • status changed from closed to reopened
  • next_action changed from no action to add to build
  • summary changed from Lid switch OFW power off should be consistant across XO versions to Lid switch OFW power off should be consistent across XO versions
  • version deleted
  • milestone deleted
  • resolution deleted

The lid switch power off has become useful, but recent work on XO-1 has made the lack of it irritating to me, so I've fixed it in svn 2991.

Changed 2 years ago by Quozl

  • next_action changed from add to build to add to release

Changed 2 years ago by Quozl

  • status changed from reopened to closed
  • next_action changed from add to release to no action
  • resolution set to fixed

Is in Q2F12.

Changed 2 years ago by Quozl

Is in Q3C07, though no change to behaviour. Only a source code move with no functional effect.

Changed 2 years ago by Quozl

This enhancement introduced an unexpected behaviour on XO-1, see #12077.

Note: See TracTickets for help on using tickets.