Ticket #11563 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

inaccuracy with conversion to unix timestamps

Reported by: dsd Owned by: martin.langhoff
Priority: normal Milestone: Not Triaged
Component: ofw - open firmware Version: not specified
Keywords: Cc: martin.langhoff
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

We are seeing a problem with rtcreset.sig verification when dealing with certain dates. The "current RTC time" field in the rtcreset.sig file matches what is listed in the rtc-timestamp chosen property, but the firmware incorrectly complains that there is a mismatch.

I have narrowed this down to a bug relating to conversion to/from unix timestamps. This demonstrates the issue:

" 20131209T000350Z" decode-timestamp >unix-seconds unix-seconds>

The returned date is 8th December 2013 - it should be the 9th, as it was in the input.

Change History

Changed 2 years ago by wmb@…

  • owner changed from wmb@… to Quozl
  • next_action changed from never set to test in build

Fixed by svn 2792 - the leap year calculations were broken.

Changed 2 years ago by Quozl

  • next_action changed from test in build to approve for release

Reproduced on Q4C11, Q3B23, Q2F05.

Tested fine in Q4C11ja, Q3B23jg, Q2F05jf.

What releases do you need made, Daniel?

Changed 2 years ago by dsd

  • cc martin.langhoff added

That's a question for Martin.

Changed 2 years ago by Quozl

Fixed in Q4C12.

Changed 2 years ago by Quozl

  • owner changed from Quozl to martin.langhoff
  • next_action changed from approve for release to communicate

Changed 2 years ago by Quozl

  • status changed from new to closed
  • next_action changed from communicate to no action
  • resolution set to fixed

Released in Q2F06 and Q3C01.

Note: See TracTickets for help on using tickets.