Opened 3 years ago

Closed 2 years ago

#11691 closed defect (fixed)

Give feedback during activity saving process

Reported by: martin.langhoff Owned by: erikos
Priority: normal Milestone: 12.1.0
Component: sugar-toolkit Version: not specified
Keywords: Cc: manuq, godiard, dsd
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

Steps to repro:

  • On an XO
  • Open Record activity, in a _new_ session
  • Take many pictures, 20 or so
  • Close it
  • In the Name-this-Journal entry change the name (or not), then click the "check" icon to save&close
  • No UI feedbackwhile it's saving! Easy to think it is hung

Ideally, a progress bar. At least a busy cursor spinner is needed here.

Change History (12)

comment:1 Changed 3 years ago by greenfeld

If this is what I think this is, the Naming Alert has been removed from future versions of Sugar:

http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime

However saving progress information might still be nice.

comment:2 Changed 3 years ago by godiard

We need change this behavior in Record anyway (saving the media on exit).

There are many reports of kids loosing all the production when the activity crash.

comment:3 Changed 3 years ago by martin.langhoff

That some actitivites will save large / slow files on exit. We do need a spinner there.

Saving media duringthe session in Record seems like a good idea, but is a different bug (and fix) :)

comment:4 Changed 2 years ago by erikos

  • Action Needed changed from design to code

A simple spinner for an activity would be:

diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index fdf9827..34e9729 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -897,6 +897,7 @@ class Activity(Window, gtk.Container):
         if not self.can_close():
             return
 
+        self.window.set_cursor(gtk.gdk.Cursor(gtk.gdk.WATCH))
         self.emit('_closing')
 
         if not self._closing:

and for the toolkit-gtk3 respectively: "self.get_window().set_cursor(Gdk.Cursor(Gdk.CursorType.WATCH))"

Ihave applied it here locally and will report back how it feels like.

comment:5 Changed 2 years ago by erikos

  • Summary changed from Name-this-Journal-Entry dialog does not show progress nor wait spinner while saving to Give feedback during activity saving process

I have been tried a few activities and it feels quite good to have the cursor-change feedback during the activity save. Of course this works only for python activities. But Etoys has their own saving mechanics with saving feedback. There is only one more non Python app (Scratch), so we should be ok.

comment:6 Changed 2 years ago by dsd

  • Cc dsd added

Any news here? The trivial patch above looks good to me.

comment:7 Changed 2 years ago by manuq

I have tested it and also think is useful.

comment:8 Changed 2 years ago by erikos

Ok, Gary also gave positive feedback about the design and how it feels like. We need to patch sugar-toolkit and sugar-toolkit-gtk3 for this in order to be consistent. I will post patches to sugar-devel.

comment:10 Changed 2 years ago by dsd

  • Action Needed changed from review to add to build

Fixed in sugar-toolkit-0.96.2

comment:11 Changed 2 years ago by pbrobinson

  • Action Needed changed from add to build to test in build

fix is in os13

comment:12 Changed 2 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

We now show a busy cursor after the stop button is pressed for an activity in 12.1.0 os13.

Note: See TracTickets for help on using tickets.