Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#11723 closed defect (fixed)

OFW XO-1.75 - only escape key should escape to prompt

Reported by: martin.langhoff Owned by: Quozl
Priority: normal Milestone: 12.1.0
Component: ofw - open firmware Version: not specified
Keywords: Cc: reuben, quozl, greenfeld, martin.langhoff, wmb@…
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

For consistency with earlier models, and usability on unlocked laptops.

Change History (14)

comment:1 Changed 3 years ago by pgf

what exactly is the problem? i vastly prefer not having to worry about how many times i hit the interrupting key. with ESC, the second key gets interpreted as the start of an ANSI sequence, and OFW gets mad when it's not. with return or space, nothing bad happens.

comment:2 Changed 3 years ago by wmb@…

  • Status changed from new to assigned

The problem is that children routinely bang on the keyboard when the system is booting.

comment:3 Changed 3 years ago by pgf

oh. :-)

comment:4 Changed 3 years ago by wmb@…

  • Owner changed from wmb@… to martin.langhoff
  • Status changed from assigned to new

Fixed by svn 2893. Test build at http://dev.laptop.org/~wmb/q4d05mb.rom .

Reassigned to martin. Please reassign to Quozl and change Action Needed to "add to release" if testing succeeds.

comment:5 Changed 3 years ago by wmb@…

  • Action Needed changed from never set to test in build

comment:6 Changed 3 years ago by wmb@…

Actually, it is svn 2916

comment:7 Changed 3 years ago by martin.langhoff

  • Cc greenfeld added
  • Owner changed from martin.langhoff to wmb@…

Thanks! I'll test tomorrow with Sam's help and report bac

(BTW, we don't do ownership changes in our workflow, ownership should stick with the main programmer behind it :-) ).

comment:8 Changed 3 years ago by Quozl

  • Cc martin.langhoff wmb@… added
  • Owner changed from wmb@… to Quozl
  • Status changed from new to assigned

Reviewed. The core countdown function remained in place. Fixed in svn 2918. The change also loses the ability to type an Open Firmware command after the Escape key. Please test build q4d06ja instead, using a child known to press keys.

I'd prefer that Open Firmware tickets be owned by the person doing the next action on them, rather than the person who made a code change (if any).

Stealing ownership anyway, but not taking the next action.

comment:9 Changed 3 years ago by Quozl

  • Action Needed changed from test in build to code
  • Milestone changed from 1.75-firmware to 12.1.0

comment:10 Changed 3 years ago by greenfeld

I could have sworn that someone told me that allowing any key to get an OFW prompt was an intentional change.

But I will test the fix, although I don't know the risks of bringing in Q4D06's flattened device tree at this point in time.

comment:11 Changed 3 years ago by Quozl

  • Action Needed changed from code to add to build

Yes, that was #11495. Fix is now in Q4D07. Q4D07 is being tested in factory as a solution to an untracked issue with s3-selftest on SKU202.

comment:12 Changed 3 years ago by pbrobinson

  • Action Needed changed from add to build to test in build

in OS7

comment:13 Changed 3 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from assigned to closed

We only break to the "ok" prompt in secure mode with Q4D10 (found in 12.1.0 os8).

Tested with both membrane and HS keyboards.

comment:14 Changed 3 years ago by greenfeld

with the escape key; sorry.

Note: See TracTickets for help on using tickets.