OFW XO-1.75 - only escape key should escape to prompt

[martin.langhoff]

For consistency with earlier models, and usability on unlocked laptops.

[pgf]

what exactly is the problem? i vastly prefer not having to worry about how many times i hit the interrupting key. with ESC, the second key gets interpreted as the start of an ANSI sequence, and OFW gets mad when it's not. with return or space, nothing bad happens.

[wmb@…]

The problem is that children routinely bang on the keyboard when the system is booting.

[pgf]

oh. :-)

[wmb@…]

Fixed by svn 2893. Test build at http://dev.laptop.org/~wmb/q4d05mb.rom .

Reassigned to martin. Please reassign to Quozl and change Action Needed to "add to release" if testing succeeds.

[wmb@…]

Actually, it is svn 2916

[martin.langhoff]

Thanks! I'll test tomorrow with Sam's help and report bac

(BTW, we don't do ownership changes in our workflow, ownership should stick with the main programmer behind it :-) ).

[Quozl]

Reviewed. The core countdown function remained in place. Fixed in svn 2918. The change also loses the ability to type an Open Firmware command after the Escape key. Please test build q4d06ja instead, using a child known to press keys.

I'd prefer that Open Firmware tickets be owned by the person doing the next action on them, rather than the person who made a code change (if any).

Stealing ownership anyway, but not taking the next action.

[greenfeld]

I could have sworn that someone told me that allowing any key to get an OFW prompt was an intentional change.

But I will test the fix, although I don't know the risks of bringing in Q4D06's flattened device tree at this point in time.

[Quozl]

Yes, that was #11495. Fix is now in Q4D07. Q4D07 is being tested in factory as a solution to an untracked issue with s3-selftest on SKU202.

[pbrobinson]

in OS7

[greenfeld]

We only break to the "ok" prompt in secure mode with Q4D10 (found in 12.1.0 os8).

Tested with both membrane and HS keyboards.

[greenfeld]

with the escape key; sorry.