Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#11776 closed defect (fixed)

incomplete fs-update may leave laptop bootable

Reported by: Quozl Owned by: Quozl
Priority: normal Milestone: 12.1.0
Component: build-system Version: Development build as of this date
Keywords: Cc: dsd
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description

We have already fixed zhashfs to write the zero block last, which works well with laptops that have had nothing on their internal storage.

However, if the internal storage already contains an identical partition map, it is not cleared, and so a partial fs-update can leave the laptop bootable to some extent.

Proposed fix, olpc-os-builder:bin/zhashfs to write a zeroed zero block first.

Change History (7)

comment:1 Changed 3 years ago by Quozl

Fix committed.

comment:2 Changed 3 years ago by Quozl

  • Action Needed changed from code to package
  • Cc dsd added

comment:3 Changed 3 years ago by Quozl

Fix was not in the olpc-os-builder instance used to produce 21007o2.zd.

Test case: "head -2 file.zd | grep zblock: | cut -f2 -d' '" should yield 0.

comment:4 Changed 3 years ago by dsd

  • Action Needed changed from package to test in build

Test in 12.1.0 build 8.

comment:5 Changed 2 years ago by greenfeld

  • Action Needed changed from test in build to no action
  • Resolution set to fixed
  • Status changed from new to closed

I interrupted an fs-update on a XO-1.75 with 12.1.0 os8 and the system defaulted to trying to boot off of /wlan only.

comment:6 Changed 2 years ago by Quozl

And is that what we want?

comment:7 Changed 2 years ago by greenfeld

That's a reasonable question (perhaps for another ticket):

Do we want to change OFW's boot path so it doesn't continue searching after the internal drive fails in this case?

We actually search for what appears to be four items if internal booting fails - "ext:\zimage /prober /usb/ethernet /wlan"

Note: See TracTickets for help on using tickets.