Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#11847 closed defect (fixed)

XO-1 automatic tests give no opportunity for repeating

Reported by: earias Owned by: quozl@…
Priority: high Milestone:
Component: ofw - open firmware Version: Development firmware
Keywords: Cc: reuben, wmb@…
Blocked By: Blocking:
Deployments affected: Action Needed: no action
Verified: no

Description (last modified by Quozl)

If the test starts automaticaly, and some test shows error, when I press some key, the system power off.

Instead, we would like the power to remain on, the menu to identify which tests failed, and permit the user to retest.

Change History (15)

comment:1 Changed 2 years ago by Quozl

  • Action Needed changed from never set to no action
  • Component changed from not assigned to ofw - open firmware
  • Milestone Not Triaged deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version changed from not specified to Development firmware

Thank you for your problem report.

The automatic tests started by the left-rocker key are designed to respond to the first failure by stopping, waiting for the user to press a key, and powering off.

Please use menu or test-all at the ok prompt for more detailed testing.

Related tickets: #11423 (implementation), #11427 (escape), #11612 (an external SD spurious failure), #11622 (port to XO-1), #11650 (clarify message), #11844 (another external SD spurious failure).

comment:2 Changed 2 years ago by reuben

  • Cc reuben added
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Not closed. Client cannot issue commands due to OFW security.

comment:3 Changed 2 years ago by wmb@…

Is the desired behavior to proceed to the next test?

comment:4 Changed 2 years ago by reuben

  • Cc wmb added

This was not explained to me in the same manner as reported here:

Here is the workflow:

-Using Q2F11
-Launch Self Test. Allow testall to start
-Interrupt one of the tests. (It does not require a failure)
-You will be taken back to the graphical menu
-Press any key and the system will power off.

The desired behavior is that you should either be able to continue to another test or navigate to stop sign and power off.

comment:5 Changed 2 years ago by reuben

Any progress here?

comment:6 follow-up: Changed 2 years ago by Quozl

  • Action Needed changed from no action to design
  • Cc wmb@… added; wmb removed

Reuben, I remain in doubt as to my comprehension of your requirements, sorry. Here's a proposed behaviour:

  • You want to be able to interrupt the automatic test using the escape key, be given the test menu, and resume manual control?
  • You want a test failure, (such as the SD test in Q2F10), to proceed to the next test, and when all tests are done to redisplay the test menu, and resume manual control?

comment:7 in reply to: ↑ 6 ; follow-up: Changed 2 years ago by reuben

Replying to Quozl:

Reuben, I remain in doubt as to my comprehension of your requirements, sorry. Here's a proposed behaviour:

  • You want to be able to interrupt the automatic test using the escape key, be given the test menu, and resume manual control?

From my understanding: When the automatic tests are escaped using only the *escape* key, they should be given the test menu, and should be able to navigate the test menu. The test menu should allow them to run additional tests or move to the stop button to power off.

  • You want a test failure, (such as the SD test in Q2F10), to proceed to the next test, and when all tests are done to redisplay the test menu, and resume manual control?

In the event of test failure, the testing process should be paused, requiring user intervention to acknowledge the test failure, and then pressing any key then should resume the testing process.

I believe in both cases when the tests have finished the unit should power-off.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 2 years ago by Quozl

  • Action Needed changed from design to review

Replying to reuben:

Replying to Quozl:

Reuben, I remain in doubt as to my comprehension of your requirements, sorry. Here's a proposed behaviour:

  • You want to be able to interrupt the automatic test using the escape key, be given the test menu, and resume manual control?

From my understanding: When the automatic tests are escaped using only the *escape* key, they should be given the test menu, and should be able to navigate the test menu. The test menu should allow them to run additional tests or move to the stop button to power off.

Thanks. Escape key was being ignored in the two second countdown after each test. That's just after the "Okay" but before the menu refreshes. I have fixed that.

  • You want a test failure, (such as the SD test in Q2F10), to proceed to the next test, and when all tests are done to redisplay the test menu, and resume manual control?

In the event of test failure, the testing process should be paused, requiring user intervention to acknowledge the test failure, and then pressing any key then should resume the testing process.

Okay. I have implemented that.

I believe in both cases when the tests have finished the unit should power-off.

I don't like that, because power off is indistinguishable from unit failure.

In Q2F10, when all tests have passed it says "All automatic tests passed successfully" on a green background, and waits for any key.

I propose that for an all tests run that contains at least one test fail, it should say "Some tests failed" on a red background, and wait for any key. I have implemented that.

Alternatively, these two messages could be omitted, leaving the exit icon selected, and the coloured borders around each test will indicate the success or failure.

Please test http://dev.laptop.org/~quozl/q2f11jf.rom

Test cases

  • gamekey-auto-menu then hit escape immediately, should exit,
  • gamekey-auto-menu then navigate to exit, should exit,
  • gamekey-auto-menu then do not interact, should start tests, at end of tests should display result, then should return to menu with exit button active,
  • as above but press escape during the Okay pause after a test, should return to menu,
  • that a failed test causes the test to be reported, and the end of tests should report some tests failed.

To force a test fail of the CPU test,

ok dev /cpu
ok patch true false selftest
ok dend

comment:9 Changed 2 years ago by Quozl

Is in svn 2998.

comment:10 in reply to: ↑ 8 ; follow-up: Changed 2 years ago by reuben

Replying to Quozl:

Replying to reuben:

Replying to Quozl:

Reuben, I remain in doubt as to my comprehension of your requirements, sorry. Here's a proposed behaviour:

  • You want to be able to interrupt the automatic test using the escape key, be given the test menu, and resume manual control?

From my understanding: When the automatic tests are escaped using only the *escape* key, they should be given the test menu, and should be able to navigate the test menu. The test menu should allow them to run additional tests or move to the stop button to power off.

Thanks. Escape key was being ignored in the two second countdown after each test. That's just after the "Okay" but before the menu refreshes. I have fixed that.

  • You want a test failure, (such as the SD test in Q2F10), to proceed to the next test, and when all tests are done to redisplay the test menu, and resume manual control?

In the event of test failure, the testing process should be paused, requiring user intervention to acknowledge the test failure, and then pressing any key then should resume the testing process.

Okay. I have implemented that.

I believe in both cases when the tests have finished the unit should power-off.

I don't like that, because power off is indistinguishable from unit failure.

In Q2F10, when all tests have passed it says "All automatic tests passed successfully" on a green background, and waits for any key.

I propose that for an all tests run that contains at least one test fail, it should say "Some tests failed" on a red background, and wait for any key. I have implemented that.

Alternatively, these two messages could be omitted, leaving the exit icon selected, and the coloured borders around each test will indicate the success or failure.

I like this alternative idea. A common request is a report at the end of testing summarizing all tests passed or showing which tests failed.

Please test http://dev.laptop.org/~quozl/q2f11jf.rom

Test cases

  • gamekey-auto-menu then hit escape immediately, should exit,
  • gamekey-auto-menu then navigate to exit, should exit,
  • gamekey-auto-menu then do not interact, should start tests, at end of tests should display result, then should return to menu with exit button active,
  • as above but press escape during the Okay pause after a test, should return to menu,
  • that a failed test causes the test to be reported, and the end of tests should report some tests failed.

To force a test fail of the CPU test,

ok dev /cpu
ok patch true false selftest
ok dend

comment:11 in reply to: ↑ 10 Changed 2 years ago by Quozl

Replying to reuben:

I like this alternative idea. A common request is a report at the end of testing summarizing all tests passed or showing which tests failed.

Thanks. Please test http://dev.laptop.org/~quozl/q2f11jg.rom

This version displays the overall result of the automatic tests like this:

overall resultboxesselected itemimplication
passall boxes are greenthe quit menu itemtesting is complete
failat least one box is red, the rest are greenthe play menu itema need to test again

It does not power off unless directed to do so.

For testing of the logic, the following can be used:

ok : xf  ( -- )  cr type 0 true  ;  \ make a no-operation test
ok patch xf (mfg-test-dev) mfg-test-dev  \ use it for menu testing
ok patch xf (mfg-test-dev) gfx-test-dev  \ use it for menu testing
ok patch c8 7d0 mfg-test-result  \ decrease delay after test success
ok patch 32 c8 play-item  \ decrease delay between tests in menu

comment:12 Changed 2 years ago by reuben

tested okay by earias

comment:13 Changed 2 years ago by Quozl

  • Action Needed changed from review to add to release
  • Description modified (diff)
  • Summary changed from Firmware q2f10: Test Hardware: If fails power off to XO-1 automatic tests give no opportunity for repeating

Thanks. Will be in next release.

Adjusted ticket summary and description to match what has been learned.

comment:14 Changed 2 years ago by Quozl

  • Action Needed changed from add to release to no action
  • Resolution set to fixed
  • Status changed from reopened to closed

Is in Q2F12.

comment:15 Changed 2 years ago by Quozl

Is in Q3C07.

Note: See TracTickets for help on using tickets.