Ticket #12163 (closed defect: fixed)

Opened 22 months ago

Last modified 20 months ago

AbiWord 2.9 + touch handles needs packaging

Reported by: dsd Owned by: godiard
Priority: high Milestone: 13.1.0
Component: write-activity (abiword) Version: not specified
Keywords: Cc: garnacho, pbrobinson, erikos
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

After a quick IRC discussion with uwog we have a plan for abiword/touch handles/F18.

From the 13.1.0 meeting earlier, we'll have to ship a forked package in the mean time (starting this week), Gonzalo is in charge of that. But with the above plan in place, it shouldn't be long before abiword-2.9.x is in Fedora and Carlos's work is in the official sources, at which point the fork can be dropped.

Attachments

changes-after-2.9.3.diff (455.5 kB) - added by godiard 22 months ago.
abiword-text-handles.diff (50.2 kB) - added by godiard 22 months ago.

Change History

  Changed 22 months ago by pbrobinson

  Changed 22 months ago by dsd

Thanks Peter. I've archived it here just in case: http://dev.laptop.org/~dsd/20121009/

Gonzalo, Peter says he can help with the package building, just send him the patch for touch selections once you have checked that it applies cleanly to 2.9.3 sources.

follow-up: ↓ 4   Changed 22 months ago by pbrobinson

does there need to be work done with pyabiword as well?

in reply to: ↑ 3   Changed 22 months ago by godiard

Replying to pbrobinson:

does there need to be work done with pyabiword as well?

We will use the dynamic bindings. Should create a different package or may be all in the same package?

follow-up: ↓ 6   Changed 22 months ago by godiard

I think I will need include the introspection info in libabiword rpm. Evince is doing that.

in reply to: ↑ 5   Changed 22 months ago by pbrobinson

Replying to godiard:

I think I will need include the introspection info in libabiword rpm. Evince is doing that.

That makes perfect sense, no need to have it in separate packages. It was more a query whether we'd be using introspection (last time I looked libabiword didn't have it) or the pyabiword python bindings. Presumably pyabiword will be obsolete once the bindings are in place.

Changed 22 months ago by godiard

Changed 22 months ago by godiard

follow-up: ↓ 8   Changed 22 months ago by godiard

Peter, the patch provided by Carlos is abiword-text-handles.diff, but does not apply over 2.9.3

The file changes-after-2.9.3.diff is the difference between 2.9.3 and the svn version where the patch provided by Carlos apply.

Tell me if you need anything more.

in reply to: ↑ 7 ; follow-up: ↓ 11   Changed 22 months ago by pbrobinson

Replying to godiard:

Peter, the patch provided by Carlos is abiword-text-handles.diff, but does not apply over 2.9.3

So 2.9.4 according to discussions on the abiword dev list today should be out RSN. So once that is out the abiword-text-handles.diff is all we should need?

The file changes-after-2.9.3.diff is the difference between 2.9.3 and the svn version where the patch provided by Carlos apply.

And if 2.9.4 is out soon we shouldn't need that? Do we want a scratch release of 2.9.3 + the two patches for testing in case 2.9.4 takes more than a day or so?

follow-up: ↓ 12   Changed 22 months ago by dsd

We need whatever is available before tomorrow afternoon (thursday)

  Changed 22 months ago by dsd

Gonzalo may require it sooner if there is pending write activity work to do after we have the packages.

in reply to: ↑ 8   Changed 22 months ago by godiard

Replying to pbrobinson:

And if 2.9.4 is out soon we shouldn't need that? Do we want a scratch release of 2.9.3 + the two patches for testing in case 2.9.4 takes more than a day or so?

When abiword developers release 2.9.4, we will need that + one patch (abiword-text-handles.diff) until that change land. We hope have it landed soon, but need continue with development.

in reply to: ↑ 9   Changed 22 months ago by pbrobinson

Replying to dsd:

We need whatever is available before tomorrow afternoon (thursday)

Err hence the reason for the questions

  Changed 22 months ago by dsd

To clarify, it is what you were suspecting: 2.9.4 + patch will be fine only if it is released tomorrow. If that doesn't happen (the likely case, I think), we need 2.9.3 + two patches.

  Changed 22 months ago by pbrobinson

2.9.3 build fails

In file included from ev_UnixKeysym2ucs.h:7:0,

from ev_UnixKeysym2ucs.cpp:34:

../../../../src/af/util/xp/ut_types.h:96:58: fatal error: ut_export.h: No such file or directory compilation terminated.

http://koji.fedoraproject.org/koji/taskinfo?taskID=4580641

Is there an incorrect include path or something? The missing file looks to be part of abiword AFAICT

  Changed 22 months ago by garnacho

It seems that file (src/af/util/xp/ut_export.h) should be part of the changes-after-2.9.3.diff patch, it was added on Jun 26th after the 2.9.3 release, although I can't see it in the patching logs

  Changed 22 months ago by dsd

I took a different approach, starting packaging from a svn snapshot from today. Carlos's patch goes cleanly on top. And also had to fix/workaround a couple of challenges with building the introspection bindings.

Resultant packages: http://dev.laptop.org/~dsd/20121011/

Unfortunately, the new Write activity crashes with segmentation fault upon loading :(

  Changed 22 months ago by godiard

Thanks, I am looking if can find something wrong in the activity.

  Changed 22 months ago by dsd

Uploaded ARM RPMs there too, perhaps you could test them while I investigate the crash on x86.

  Changed 22 months ago by dsd

Discussed on IRC, we were missing some introspection patches.

Write-80 released, and abiword-2.9.3-1.git20121011.fc18.olpc2 is in my public_rpms.

  Changed 22 months ago by dsd

  • next_action changed from never set to add to build

  Changed 22 months ago by dsd

  • next_action changed from add to build to test in build

Test in 13.1.0 build 6

  Changed 20 months ago by greenfeld

  • status changed from new to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

A custom abiword RPM is in 13.1.0 os12/13 which can be used with the touchscreen in ebook mode. Handles appear allowing text selection, although one of the selection handles appears to be used if not selecting text instead of the centered "I-bar/cursor-usage" handle.

Note: See TracTickets for help on using tickets.