Opened 2 years ago

Closed 2 years ago

#12186 closed defect (fixed)

?compare-spec-line called with data-buffer 0

Reported by: dsd Owned by: Quozl
Priority: normal Milestone: Not Triaged
Component: ofw - open firmware Version: not specified
Keywords: Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: package
Verified: no

Description

On IRC we noticed that zblocks: calls ?compare-spec-line before initialising data-buffer.

That is fixed in r3369, but debugging ?compare-spec-line while doing a secure fs-update and checking the return stack shows that size: is calling ?compare-spec-line also before data-buffer is initialised.

Change History (5)

comment:1 Changed 2 years ago by wmb@…

  • Owner changed from wmb@… to Quozl

A little birdie in the back of my head told me that this "size:" feature was going to be "fun".

comment:2 Changed 2 years ago by Quozl

  • Action Needed changed from never set to testcase
  • Cc Quozl removed

Fixed in svn 3371. Unsigned fs-update tested.
Can I have a signed build with size: included please, Daniel?

comment:3 Changed 2 years ago by dsd

Thanks. Tested, ?compare-spec-line is first called with a buffer of 0x1000000 - looks good.

Probably easier than me uploading a signed build is you generating an unsigned fs.zip with something like:

	echo 31006o2 > version.txt
	cp 31006o2.zd.zsp data.img
	zip -j -n .img:.txt fs.zip data.img version.txt

Then flash it with:

false to require-signatures?
try-fs-update

comment:4 Changed 2 years ago by Quozl

  • Action Needed changed from testcase to package

Thanks, tested fine.

comment:5 Changed 2 years ago by wmb@…

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.