Ticket #12186 (closed defect: fixed)

Opened 22 months ago

Last modified 20 months ago

?compare-spec-line called with data-buffer 0

Reported by: dsd Owned by: Quozl
Priority: normal Milestone: Not Triaged
Component: ofw - open firmware Version: not specified
Keywords: Cc:
Action Needed: package Verified: no
Deployments affected: Blocked By:
Blocking:

Description

On IRC we noticed that zblocks: calls ?compare-spec-line before initialising data-buffer.

That is fixed in r3369, but debugging ?compare-spec-line while doing a secure fs-update and checking the return stack shows that size: is calling ?compare-spec-line also before data-buffer is initialised.

Change History

Changed 22 months ago by wmb@…

  • owner changed from wmb@… to Quozl

A little birdie in the back of my head told me that this "size:" feature was going to be "fun".

Changed 22 months ago by Quozl

  • cc Quozl removed
  • next_action changed from never set to testcase

Fixed in svn 3371. Unsigned fs-update tested. Can I have a signed build with size: included please, Daniel?

Changed 22 months ago by dsd

Thanks. Tested, ?compare-spec-line is first called with a buffer of 0x1000000 - looks good.

Probably easier than me uploading a signed build is you generating an unsigned fs.zip with something like:

	echo 31006o2 > version.txt
	cp 31006o2.zd.zsp data.img
	zip -j -n .img:.txt fs.zip data.img version.txt

Then flash it with:

false to require-signatures?
try-fs-update

Changed 22 months ago by Quozl

  • next_action changed from testcase to package

Thanks, tested fine.

Changed 20 months ago by wmb@…

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.