Better signify hardware test success/failure

[sridhar]

The automated hardware test now uses the graphical OFW menu system. This is a significant advancement. However, it is still not clear enough whether the tests have been successful or not, because the user needs to know that a green box is good and a red box is bad. I suggest that when the user is returned to the menu at the end of the tests, a clear message is shown on the screen:

• "All hardware tests passed successfully"
• "An error was found in the hardware tests. Please review the red boxes."

[sridhar]

Downstream report: https://sugardextrose.org/issues/2947

[Quozl]

A failure is already very obvious when it occurs; a red screen is shown, and the sequence demands user response by saying Selftest failed and Press any key to proceed.

User procedures should be written to ensure this is noted at the time of failure rather than relying on the unit to keep this state until the end of the sequence, since it is not known that the unit will be able to keep this state if there is a failure of memory, processor, or a keyboard key is jammed.

svn 3559 adds an overall test result screen that is shown when the user is returned to the menu at the end of the tests. It shows either:

• a green tick on a white background with All hardware tests passed., or
• a black cross on a red background with Some hardware tests failed. Please review red boxes..

http://dev.laptop.org/~quozl/q7b16jb.rom is a build of this version, with a forced test failure for 8686 wireless cards.

Test case: hold down the left rocker key, press power button, allow all tests to run to completion, examine result screen.

[Quozl]

Passed internal tests.

[Quozl]

Is in Q7B17.