Opened 7 years ago

Closed 7 years ago

#1396 closed defect (fixed)

Ebook reader should suspend on idleness

Reported by: jg Owned by: cjb
Priority: blocker Milestone: Update.1
Component: power manager (OHM) Version: Development build as of this date
Keywords: power, rainbow-integration Cc: cjb, mstone, rwh, tomeu
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

We'd like a good way to suspend explicitly: we don't want to force the laptop to be closed to suspend (though it should do that too), because the antennae may have been carefully positioned for best use (closing the laptop will put the antennae possibly down on the ground, which is a really bad place for them to be).

So by moving shutdown someplace else (#1395), we free the button for suspend use. When suspended this way (or when the laptop is closed) the screen should be turned off.

This shouldn't really be done until the UI for shutdown is designed by Eben.

Attachments (2)

fix_enable_sleep.diff (1.1 KB) - added by rwh 7 years ago.
hwmanager_dbus.diff (613 bytes) - added by rwh 7 years ago.

Download all attachments as: .zip

Change History (39)

comment:1 Changed 7 years ago by jg

  • Keywords power added
  • Verified unset

comment:2 Changed 7 years ago by jg

Bug #1290 is an example bug report for another reason to make the button suspend rather than shutdown.

comment:3 Changed 7 years ago by jg

  • Milestone changed from BTest-4 to Trial-2
  • Verified unset

comment:4 Changed 7 years ago by marco

  • Component changed from sugar to interface-design
  • Milestone changed from Trial-2 to CTest
  • Owner changed from dcbw to Eben

comment:5 Changed 7 years ago by Eben

  • Component changed from interface-design to sugar
  • Owner changed from Eben to dcbw

#1395 Now has a UI design for placement of the shutdown button in software.

comment:6 Changed 7 years ago by kimquirk

#1311 is a dup of this one.

comment:7 Changed 7 years ago by jg

  • Milestone changed from CTest to Trial-2
  • Owner changed from dcbw to cjb
  • Priority changed from high to blocker
  • Version set to Build 406.14

CJB has a patch to do the first of these (replacing shutdown with suspend), though it seems to have some issues to be sorted out in testing I did on 6/15.

I'll assign it to him for the moment, to clean up the first piece (making the power button suspend).

comment:8 Changed 7 years ago by marco

  • Component changed from sugar to power manager
  • Summary changed from Power button should suspend the machine. Shutdown should be implemented elsewhere. to Power button should suspend the machine

comment:9 follow-up: Changed 7 years ago by jg

  • Version changed from Build 406.14 to Development build as of this date

Shutdown is now implemented; Chris, please get your sugar patch for the suspend button to the sugar folks ASAP.

comment:10 in reply to: ↑ 9 Changed 7 years ago by cjb

Replying to jg:

Shutdown is now implemented; Chris, please get your sugar patch for the suspend button to the sugar folks ASAP.

I can (and the patches have already been on the sugar list), but I would rather we fix the SCI bug (#1729) first, else after the first suspend we will continuously drop to suspend, as you saw when testing out the patch.

comment:11 Changed 7 years ago by cjb

  • Summary changed from Power button should suspend the machine to Ebook reader should suspend on idleness

comment:12 Changed 7 years ago by jg

  • Cc danw added; Eben removed

Chris has the patch in hand, please apply to the ebook reader as soon as possible for Trial-2.

comment:13 Changed 7 years ago by jg

  • Cc cjb added; danw removed
  • Owner changed from cjb to danw

comment:14 Changed 7 years ago by kimquirk

  • Owner changed from danw to dcbw

comment:15 Changed 7 years ago by dcbw

  • Resolution set to fixed
  • Status changed from new to closed

'touch /home/olpc/ebook-enable-sleep' to turn it on, then relaunch ebook

comment:16 Changed 7 years ago by cjb

  • Resolution fixed deleted
  • Status changed from closed to reopened

Let's leave this open, since we might want the file test to go away (or to track getting the touched file in the Trial-2 build) before this is finished. There's still also #1729, but that's not related to the sugar work.

comment:17 Changed 7 years ago by jg

  • Milestone changed from Trial-2 to Trial-3

comment:18 Changed 7 years ago by cjb

  • Milestone changed from Trial-3 to Trial-2

This isn't in the build yet, and is blocking on #2401.

comment:19 Changed 7 years ago by jg

This is in the build, but is latent; a file must be touched to make it start working. We have to fix #2401 to get full ebook.

comment:20 Changed 7 years ago by jg

  • Milestone changed from Trial-2 to Trial-3

comment:21 Changed 7 years ago by cjb

Will retest.

comment:22 Changed 7 years ago by kimquirk

  • Milestone changed from Trial-3 to First Deployment, V1.0

Once all the suspend/resume problems are cleared out, this can be re-evaluated. Moving it to FRS.

comment:23 Changed 7 years ago by jg

  • Owner changed from dcbw to jg
  • Status changed from reopened to new

comment:24 Changed 7 years ago by jg

  • Owner changed from jg to cjb

comment:25 Changed 7 years ago by jg

  • Milestone changed from Update.2 to Update.1

comment:26 Changed 7 years ago by jg

  • Cc mstone rwh added
  • Keywords rainbow-integration added

comment:27 Changed 7 years ago by cjb

This isn't working anymore; Read is being disallowed from sending dbus messages to olpc-hardware-manager.

Changed 7 years ago by rwh

Changed 7 years ago by rwh

comment:28 Changed 7 years ago by marco

Patches make sense to me but I don't see a reason to turn it on/off depending on the presence of a file anymore. Unless someone has good reason for it, I'd just to turn it always on.

comment:29 follow-up: Changed 7 years ago by cjb

Isn't jhbuild one such reason, or qemu, or using an older XO without suspend support?

We are going to provide the file in the builds by default, of course, so it will be default-on.

comment:30 in reply to: ↑ 29 Changed 7 years ago by marco

Replying to cjb:

Isn't jhbuild one such reason, or qemu, or using an older XO without suspend support?

With jhbuild, olpc-hardware-manager will not be running, which is handled by the try/except. I tend to think the other two cases should be handled by olpc-hardware-manager (if they are not already) and not by the activity).

comment:31 Changed 7 years ago by marco

Built an rpm with Reinier patch:
olpc-hardware-manager-0.4.2-1.olpc2

comment:32 Changed 7 years ago by tomeu

Read-41.xo will check for /etc/inhibit-ebook-sleep at startup.

comment:33 Changed 7 years ago by rwh

  • Cc tomeu added

Thanks; makes more sense to me!

comment:34 Changed 7 years ago by rwh

  • Owner changed from cjb to dgilmore

Verified in joyride 1546, please tag olpc-hardware-manager-0.4.2-1.olpc2 and Read-41.xo for update-1.

comment:35 Changed 7 years ago by dgilmore

  • Owner changed from dgilmore to ApprovalForUpdate

comment:36 Changed 7 years ago by jg

  • Owner changed from ApprovalForUpdate to cjb

comment:37 Changed 7 years ago by jg

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.