After suspend/resume, camera shows strange colormap

[cjb]

After suspend/resume on my B3, the camera activity shows a strange colormap. When I quit the camera activity and restart it, the colors are back to normal. If I suspend/resume again, they go strange once more.

Photo attached. The red object is a (very bright white) light.

[cjb]

Too large to attach, so it's here:

http://dev.laptop.org/~cjb/camera.jpg

Note from the images at the bottom of the screen that the effect doesn't show up in screenshots, even while it's doing so in the Xv main image.

[kimquirk]

Would like to fix this on the B4 boards.

[kimquirk]

Would like to fix this on the B4 boards.

[erikb]

uploaded a simple app which just displays video to help with debugging

[erikb]

not sure why, but you have to launch the attached activity from the console

sugar-activity xv

[cjb]

I get a black screen and no camera LED comes on, no matter how I launch the (latest) xv.activity. The stock camera.activity works.

[cjb]

Ah, I get a traceback about ActivityToolbox not existing. I bet 406.15 is too old, then.

[erikb]

It seems that this bug is downstream of v4l2. Explanation: pictures taken by the camera activity after suspend have the correct colors... and those pictures are made by grabbing buffers from the same pipeline to the xv sink (where they are displayed in technicolor).

[cjb]

Reproduced with pure xvtest, which also gets corrupted on resume. Over to Jordan, corbet is off the hook. :)

[JordanCrouse]

Fixed twice... :) Basically, we were only restoring 255 of the LUT table entries - totally missing the last one, which was resulting in the pretty colors. This was fixed by adjusting the offsets in the lxfb driver. However - we should have also been setting up the video palette when we started up video; had we been doing that, we wouldn't have seen this problem. So, both the x driver and the kernel driver were fixed, and we're happy.

Reassigning to kim to verify.

[kimquirk]

Since it is believed to be fixed, I am lowering the priority. John - can you try to retest this?

[cjb]

Tested fixed, closed.