Opened 7 years ago

Closed 7 years ago

#2099 closed defect (fixed)

Sugar shouldn't let the two "My Colors" be identical

Reported by: Zack Owned by: marco
Priority: normal Milestone: Trial-3
Component: sugar Version:
Keywords: Cc: marco, Zack, Eben, walter
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

When I first booted 499, sugar's default colors were both the same. I accepted that, and as I expected, most of my icons are not recognizable, due to being one color.

Change History (16)

comment:1 Changed 7 years ago by marco

Please attach your .sugar/default/config

comment:2 Changed 7 years ago by jg

  • Milestone changed from Untriaged to Trial-2

comment:3 Changed 7 years ago by marco

To clarify, Sugar choose the colors from a fixed list (which Walter provided), so we need to know which colors you was using exactly to be able to do something about it.

comment:4 Changed 7 years ago by marco

Zack, can you provide your config please? Can't do much about this without it.

comment:5 Changed 7 years ago by jg

  • Owner changed from dcbw to Zack

comment:6 Changed 7 years ago by bert

  • Cc marco added

In build 526 I got colors that were not identical, but so close the icons still were pretty much unrecognizable: FFFA00,F8E800

comment:7 Changed 7 years ago by marco

  • Owner changed from Zack to walter

Reassigning to Walter. Please let me know how I should update the list of colors.

comment:8 Changed 7 years ago by coderanger

Adding reporter to CC list

comment:9 Changed 7 years ago by coderanger

  • Cc Zack added

Adding reporter to CC list

comment:10 Changed 7 years ago by marco

  • Cc Eben added

Adding Eben. Eben, should we just drop this color from the list? I'm mostly wondering if this is the only case or there are problem in the way the color list was generated.

comment:11 Changed 7 years ago by Eben

  • Cc walter added

Well, the list of colors is neatly defined in such a way that tossing one from the list isn't really a good idea. There are 5 "groups" of colors, where each group has all possible combinations of stroke and fill assuming 6 distinct hues. That is, there are 6*6*5=180 color pairs in total, and removing any of them will leave a hole in the newly designed color picker.

Walter, do you want to revisit these particular edge cases? Glancing at them again, I see a few that might need tweaking:

(page, fill, stroke)
(5, yellow, yellow)
(4, orange, yellow)
(3, yellow, orange)

Of course, the latter 2 are really the same pair, inverted. The rest seem distinct enough.

comment:12 Changed 7 years ago by walter

Let's change the yellow yellow pair from FFFA00,F8E800 to FFFA00,EDDE00

comment:13 Changed 7 years ago by marco

  • Owner changed from walter to marco

comment:14 Changed 7 years ago by marco

  • Resolution set to fixed
  • Status changed from new to closed

Applied the fix suggested by Walter.

comment:15 Changed 2 years ago by Micah

  • Blocked By 12152 added

comment:16 Changed 2 years ago by Micah

  • Blocked By 12152 removed
Note: See TracTickets for help on using tickets.