Ticket #2495 (closed enhancement: fixed)

Opened 7 years ago

Last modified 4 years ago

Invert colors

Reported by: nathalia.sautchuk Owned by: nathalia.sautchuk
Priority: low Milestone: 10.1.3
Component: paint/drawing-activity (oficina) Version:
Keywords: Cc:
Action Needed: no action Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Implement invert colors

Attachments

invert-colors.svg (12.6 kB) - added by ayush 4 years ago.
Icon designed for invert color effect
0001-Added-Invert-Color-Effect-to-Paint-Activity-OLPC-249.patch (22.6 kB) - added by ayush 4 years ago.
Revised patch

Change History

Changed 7 years ago by jg

  • milestone changed from Untriaged to Trial-3

Changed 7 years ago by kimquirk

  • milestone changed from Trial-3 to V1.1

Changed 4 years ago by ayush

Icon designed for invert color effect

Changed 4 years ago by ayush

Revised patch

Changed 4 years ago by godiard

  • status changed from new to closed
  • next_action set to never set
  • resolution set to fixed

Changed 4 years ago by godiard

  • next_action changed from never set to package

Changed 4 years ago by godiard

  • next_action changed from package to test in build
  • milestone changed from Future Release to 10.1.3

Will be in 353.

|TestCase| In the effects tab there are a button "Invert colors", this will affect all if there are not a selection or the selection if exists.

Changed 4 years ago by godiard

  • status changed from closed to reopened
  • next_action changed from test in build to code
  • resolution deleted

There are a problem, may be with the version of numpy in F11. In F13 works ok.

  File "/home/olpc/Activities/Paint.activity/toolbox.py", line 1334, in invert_colors
    self._activity.area.invert_colors(widget)
  File "/home/olpc/Activities/Paint.activity/Area.py", line 964, in invert_colors
    8)
TypeError: pixbuf_new_from_array() argument 1 must be array, not numpy.ndarray
Traceback (most recent call last):
  File "/home/olpc/Activities/Paint.activity/toolbox.py", line 1334, in invert_colors
    self._activity.area.invert_colors(widget)
  File "/home/olpc/Activities/Paint.activity/Area.py", line 964, in invert_colors
    8)
TypeError: pixbuf_new_from_array() argument 1 must be array, not numpy.ndarray

Changed 4 years ago by godiard

  • next_action changed from code to package

Implemented a secondary code for F11 because gtk is compiled different.

http://git.sugarlabs.org/paint/mainline/commit/5ddde9d8119e70c9ba2698086784cd504757608b

Changed 4 years ago by godiard

  • next_action changed from package to test in build

Will be in os358

Changed 4 years ago by greenfeld

  • status changed from reopened to closed
  • next_action changed from test in build to no action
  • resolution set to fixed

There is now an invert effect in Paint, although it takes a bit of time to run on an XO-1 (with no busy feedback given).

Tested with Paint-30 in 10.1.3 os358 (F11) as well as SoaS F14 to check both codepaths.

Note: See TracTickets for help on using tickets.