Ticket #2541 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Read's stop button doesn't work when it fails to open a file

Reported by: jfuhrer Owned by: tomeu
Priority: high Milestone: Trial-3
Component: sugar Version:
Keywords: Cc: marco, eben
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

OFW: Q2C18 Build: 537

There are a number of situations in which Read fails to open a pdf file - when it resumes from a USB stick, or when it tries to view a shared file, for example. All of these have been reported in trac. However, in addition to that, the close button stops working in these situations.

Attachments

Read.log Download (28.2 KB) - added by jfuhrer 7 years ago.

Change History

Changed 7 years ago by jfuhrer

Changed 7 years ago by jg

  • priority changed from normal to high
  • milestone changed from Untriaged to Trial-3

Changed 7 years ago by tomeu

  • owner changed from dcbw to tomeu
  • cc marco, eben added

Marco, Eben,

should we close the activity even if some error happens during the saving to the journal?

Of course, no error should happen and closing it as if nothing had occurred could hide some serious problem. But also not closing the activity creates an additional problem to the user.

What's the best option here? Close anyway or not?

Changed 7 years ago by tomeu

  • status changed from new to closed
  • resolution set to fixed

As writing to the DS is now asynchronous, the window of the activity is closed when the user presses the close button and the process will die when the write call finishes.

Note: See TracTickets for help on using tickets.