Opened 7 years ago

Closed 7 years ago

#2541 closed defect (fixed)

Read's stop button doesn't work when it fails to open a file

Reported by: jfuhrer Owned by: tomeu
Priority: high Milestone: Trial-3
Component: sugar Version:
Keywords: Cc: marco, eben
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

OFW: Q2C18
Build: 537

There are a number of situations in which Read fails to open a pdf file - when it resumes from a USB stick, or when it tries to view a shared file, for example. All of these have been reported in trac. However, in addition to that, the close button stops working in these situations.

Attachments (1)

Read.log (28.2 KB) - added by jfuhrer 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by jfuhrer

comment:1 Changed 7 years ago by jg

  • Milestone changed from Untriaged to Trial-3
  • Priority changed from normal to high

comment:2 Changed 7 years ago by tomeu

  • Cc marco eben added
  • Owner changed from dcbw to tomeu

Marco, Eben,

should we close the activity even if some error happens during the saving to the journal?

Of course, no error should happen and closing it as if nothing had occurred could hide some serious problem. But also not closing the activity creates an additional problem to the user.

What's the best option here? Close anyway or not?

comment:3 Changed 7 years ago by tomeu

  • Resolution set to fixed
  • Status changed from new to closed

As writing to the DS is now asynchronous, the window of the activity is closed when the user presses the close button and the process will die when the write call finishes.

Note: See TracTickets for help on using tickets.