Ticket #2551 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Record's copy features aren't working

Reported by: jfuhrer Owned by: erikb
Priority: high Milestone: Trial-2
Component: camera-activity Version:
Keywords: Cc: eben.eliason@…, tomeu@…, olpc-dev@…
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

OFW: Q2C18 Build: 537

In this build, Record was supposed to have gained the ability to let the user drag a photo onto the clipboard, or to use ctrl+C to copy it to the clipboard. Neither of these features work. If I drag a photo's thumbnail near the edge of the screen, the frame won't appear, so there's no way to drag it on. And pressing ctrl+C while selecting a thumbnail doesn't do anything.

Change History

follow-up: ↓ 4   Changed 7 years ago by erikb

  • cc eben.eliason@…, tomeu@… added
  • status changed from new to assigned
  • milestone changed from Untriaged to Trial-2

I don't know if an activity can summon the frame... CC'ing Eben & Tomeu on this to chime in on how this might be done. That said, here is how to make it work with the version you have -->
1) Click the Frame Button.
2) Drag to the Frame's clipboard region. Eben & Tomeu, is there a way to summon the frame when a drag event is initiated? That would be cool.

As for CTRL+C on the selected photo, you need to:
1) Click the photo's thumbnail
2) Click the activity's mainpanel, i.e., the gray background, which is the Activity subclass. This is a bug -- good find! Tomeu, is there a way to easily add a keyboard listener to every component in my layout?
3) click CTRL+C

Thanks for find these bugs.

  Changed 7 years ago by erikb

  • cc olpc-dev@… added

  Changed 7 years ago by jfuhrer

It would be good, if possible, to have the frame appear when a thumbnail is dragged into the frame region, because it's pretty unwieldy to press the frame button and then try to select a thumbnail, which is now mostly obscured by the frame you just summoned.

Also, I'm filing a new bug as well as the clipboard entries that are created from this aren't openable.

in reply to: ↑ 1   Changed 7 years ago by tomeu

Replying to erikb:

I don't know if an activity can summon the frame...

The frame should unhide automatically when you drag something to the border of the screen. If it doesn't then there is a bug. Not sure if the bug lays in the shell or in the activity, though.

Tomeu, is there a way to easily add a keyboard listener to every component in my layout?

I think your activity descendant (a gtk.window) should listen for key press events. If it doesn't work in all the screen area of your activity, then some element in it is kidnapping the key strokes.

A widget can kidnap keystrokes by gaining the focus and, in the callback for the event, returning True. Refer to the pygtk docs for more details about this.

  Changed 7 years ago by erikb

  • status changed from assigned to closed
  • resolution set to fixed

#2573 and #2570 fixes the ctrl+c and the drag bug, but being able to summon the frame with the initiation of a drag is a sugar ui bug (i think), and has been filed under #2574.

Also, #2554 has also been thanks to #2570.

Note: See TracTickets for help on using tickets.