Ticket #3529 (new enhancement)

Opened 7 years ago

Last modified 6 years ago

CC license support in journal, as liblicense across the XO

Reported by: paulproteus Owned by: marco
Priority: high Milestone: 9.1.0-cancelled
Component: sugar Version:
Keywords: Cc: jon@…, walter@…, sj@…, nathan@…, asheesh@…, tomeu, dgilmore, kimquirk, mstone, greg@…
Action Needed: never set Verified: no
Deployments affected: Blocked By: #7551
Blocking: #3531

Description

Creative Commons wrote a patch for the journal to show add CC licenses as well as let you choose them.

That patch is available at http://cctools.svn.sf.net/svnroot/cctools/liblicense-sugar/trunk/journal.patch .

As written in its README <http://cctools.svn.sf.net/svnroot/cctools/liblicense-sugar/trunk/README>, this requires the liblicense RPM. You should read the info in the README to see how to get the RPM.

This code was written by our summer interns and Google Summer of Code contributors, as was liblicense, but I (Asheesh Laroia, a full time software engineer at CC) am in charge of maintaining them.

I was told to assign this to the build category, but I'm not sure what that meant.

Attachments

journal_default.png (63.9 kB) - added by rejon 7 years ago.
Screenshot of journal + CC integration
journal_entry.png (52.6 kB) - added by rejon 7 years ago.
Screenshot of journal + CC integration
journal_start.png (40.1 kB) - added by rejon 7 years ago.
Screenshot of journal + CC integration

Change History

  Changed 7 years ago by rejon

  • priority changed from normal to high
  • type changed from defect to enhancement

  Changed 7 years ago by rejon

  • keywords liblicense, creativecommons, library, journal added
  • owner changed from tomeu to jg
  • component changed from journal-activity to distro

Fixed category

  Changed 7 years ago by rejon

A related enhancement that SJ wants is: https://dev.laptop.org/ticket/3531 (search by license), but shouldn't hold up integration process.

  Changed 7 years ago by rejon

Also, started a wiki page for Creative Commons + OLPC projects:

http://wiki.laptop.org/go/Creative_Commons

  Changed 7 years ago by jg

  • keywords liblicense, creativecommons, library, journal removed
  • owner changed from jg to marco
  • component changed from distro to sugar
  • milestone changed from Untriaged to First Deployment, V1.0

The patch will have to be against up to date Sugar bits if you want it integrated...

  Changed 7 years ago by jg

Note this is well past our feature freeze, it may very well wait until our V1.1. I leave the judgment to Marco.

  Changed 7 years ago by jg

  • milestone changed from First Deployment, V1.0 to V1.1

On third thought, we have enough on our plate to put this against our V1.1 release. Feature freeze was several weeks ago.

  Changed 7 years ago by rejon

JG, what is the code freeze date on V1.1? We definitely want to make this window. Also, will update this patch against latest trunk to make sure all is well.

Changed 7 years ago by rejon

Screenshot of journal + CC integration

Changed 7 years ago by rejon

Screenshot of journal + CC integration

Changed 7 years ago by rejon

Screenshot of journal + CC integration

  Changed 7 years ago by rejon

Ok, I added screenshots of what integration looks like FYI, if anyone wants and/or needs these :) Thanks!

  Changed 7 years ago by tomeu

  • cc tomeu added

  Changed 7 years ago by paulproteus

I'm maintaining a git branch now of Sugar and the Journal that have the patches

It works for me in a jhbuild. I would very, very (!!) much like some input from laptop.org people.

Follow http://wiki.laptop.org/go/Creative_Commons#How_to_try_it to try it. I'm copy-pasting the current version here:

* Install the liblicense RPM at http://downloads.sourceforge.net/cctools/liblicense-0.4-1.i386.rpm (forcing the dependencies, for now; I'll build an updated RPM soon.) * Install the Sugar branch * Install the Journal branch

You will see license icons next to everything that appears in the Journal now, and in the detailed view of any Journal item you will be able to click the license icon and select a different one.

I would *love it* if you guys would give this a shot, perhaps by pulling, and we can try to work out the remaining issues in the trunks of Sugar and the Journal.

follow-up: ↓ 13   Changed 7 years ago by rejon

  • milestone changed from Future Release to Update.2

Alright, the target is to get these into update 2...marco, tomeu, sj, jg, can you update this one so that it can be on track for update 2 due in 2-3 months...

This one is more priority since everything we have done is based upon it.

in reply to: ↑ 12 ; follow-up: ↓ 14   Changed 7 years ago by tomeu

Replying to rejon:

Alright, the target is to get these into update 2...marco, tomeu, sj, jg, can you update this one so that it can be on track for update 2 due in 2-3 months...

rejon, can you please explain why you think this should be done for update.2? I don't see it in the roadmap: http://dev.laptop.org/roadmap

I understand you want to see your work shipped, but you need to convince the right people first. In my opinion you would need to first gather some consensus about why this functionality is important to be included in the builds, then agree with Kim and Walter the milestone this should land in, and then Eben should define the user experience related to licenses. After this has happened, we can start looking at the implementation.

Just handing some patches and tell a bunch of overworked people to ship it is not the best way, I think.

in reply to: ↑ 13 ; follow-up: ↓ 15   Changed 7 years ago by sj

Ok,

Walter and I corresponded with Jon a bit. They are indeed eager to see their work in builds; but more to the point it is mostly done from their end and they want to know waht they can do to make integration and testing easier.

This will be useful in builds to start keeping proper track of licensing information, one of the pieces of information no bundle or item should travel without if we want to provide for remixing and aggregate reuse; and to provide a child-friendly way of visualizing the same.

Eben should certainly be involved in the design discussion; this is easier when it is in a testable build.

Just handing some patches and tell a bunch of overworked people to ship it is not the best way, I think.

You may be misinterpreting Jon; when he said "the goal is" he was just reporting on a discussion we had in which update.2 was suggested as a good target for what seems to be a mostly-finished patch.

Cheers, SJ

in reply to: ↑ 14   Changed 7 years ago by tomeu

Replying to sj:

Just handing some patches and tell a bunch of overworked people to ship it is not the best way, I think.

You may be misinterpreting Jon; when he said "the goal is" he was just reporting on a discussion we had in which update.2 was suggested as a good target for what seems to be a mostly-finished patch.

Ok, I'm sorry for misinterpreting and apologize if I hurt anyone's feelings. But please, try to have these conversations on public forums, so we all know what's going on and have a chance to contribute.

Samuel, imagine what would happen if all contributors started setting ticket milestones and saying what the goals are. Do you think that can work?

  Changed 7 years ago by rejon

tomeu, all is well...the cc integration work has been ongoing for some time and has been existing heavily on the CC tech team. We are eager to get this more into public, but didn't have some of these in the tracker before.

Regardless, yes, we have been having a discussion with SJ and Walter about this for some time and integration was planned for the first release, so this is already a slipped timeline.

Thanks and hope you can help us evangelize this integration....

Eben, what are the next steps?

follow-up: ↓ 19   Changed 6 years ago by dgilmore

  • cc dgilmore added

Where is the srpm for liblicense? the first step will be getting it included in fedora. then we can easily include it.

  Changed 6 years ago by marco

  • milestone changed from Update.2 to Future Release

Please post a proposal on the Sugar list if you want to get it in Update.2. See my post: http://lists.laptop.org/pipermail/sugar/2008-May/005571.html

in reply to: ↑ 17   Changed 6 years ago by paulproteus

Replying to dgilmore:

Where is the srpm for liblicense? the first step will be getting it included in fedora. then we can easily include it.

https://bugzilla.redhat.com/show_bug.cgi?id=446993 has the SRPM and .spec. It's waiting for review; how long does that typically take?

Thanks to dgilmore for helping me with packaging questions before I was ready to file that bug!

follow-up: ↓ 21   Changed 6 years ago by gnu

(As an aside, tomeu's complaint that those dern outsiders are not only posting bug reports and feature requests, but actually ADDING FEATURES and POSTING PATCHES to the Sugar code, is outrageous.

In a typical free software project, if someone contributes new features with actual working code, the maintainer doesn't tell them they need to convince somebody in the bureacracy that their feature needs to be entered into the priority queue for contemplation among the committee of guardians of the public morals. A good maintainer either applies the patch to the master sources (verbatim, or with minor or major rework for quality and style); gives the contributor access to apply the patch themselves, based on the high quality of their work; or tells the contributor to rework the patch because of specific complaints about it (e.g. quality, style, lack of documentation, lack of generality, doesn't patch cleanly into current sources, it introduces a bug, ...).

Sugar is never going to get anywhere with three guys working on it, if they refuse to include contributions from outside.

I don't want to complain about tomeu in general, he's been very helpful many times. Perhaps he had a bad day two months ago. But reactions like this one are why people say that OLPC is insular and unhelpful. The standard OLPC response to a bug or missing feature report is "we won't get around to it ourselves, but patches would be welcomed". So when patches DO show up, please DO welcome them.)

in reply to: ↑ 20   Changed 6 years ago by tomeu

The problem here is that I don't have time to do all that I should.

When a patch is submitted that addresses a clear need, I work with the submitter so the patch gets applied.

In this case, I don't know what's the need for this patch and I'm asking the submitter to gather some support from the community so there's a clear agreement on the need for this. Which item(s) from my todo list should I drop so this one gets in?

  Changed 6 years ago by rejon

  • milestone changed from Future Release to 8.2.0 (was Update.2)

Tomeu, we have been working on this in public, with Dennis Gilmore and SJ Klein. We have the code ready for a few months now and not much movement, so I'm pushing this for the next release. We have to get this out to fight bitrot.

Also, liblicense is in redhat RPM repo now, which makes this all possible now. We just need code review and to push this.

Please advise Tomeu and others on next steps.

  Changed 6 years ago by tomeu

  • cc kimquirk, mstone added

Kim, I was planning to focus on bug fixing until the release of 8.2.0. Do you want me to work on this new feature now?

Rejon, as you can see in the roadmap linked below, the period for new features proposals for Sugar 0.82 ended on May 18th, and the feature freeze happened on 21th June:

http://wiki.sugarlabs.org/go/ReleaseTeam/Roadmap

See here about how to get an exception to the feature freeze:

http://wiki.sugarlabs.org/go/ReleaseTeam#Feature_freeze

Perhaps there's some possibility that OLPC's 0.8.2 release will include a Sugar release posterior to 0.82, in that case it may be a good moment to start thinking about its inclusion in 0.83, although I'm not sure how much available time will have the maintainers in the next weeks. Michael, how probable you see this?

  Changed 6 years ago by marco

I'm happy to review/land the patch if the community thinks it's essential enough to be worth a feature freeze break and if we can get it in a committable state in ~ 1 week.

As Tomeu said, if you think this is worth a feature freeze break please follow:

http://wiki.sugarlabs.org/go/ReleaseTeam#Feature_freeze

Otherwise let's get this in early in the next cycle (just after 8 August).

  Changed 6 years ago by marco

  • milestone changed from 8.2.0 (was Update.2) to Retriage, Please!

  Changed 6 years ago by rejon

Who should be doing the re-triaging of this? We have provided the code and liblicense RPM so that it can be included. Cheers and let me know what I can do to get this to happen sooner rather than later...

  Changed 6 years ago by greg.g

  • cc greg@… added
  • next_action set to never set

  Changed 6 years ago by Eben

As promised, I posted the designs. You can find them here: http://wiki.laptop.org/go/Designs/Creative_commons

  Changed 6 years ago by marco

  • milestone changed from Not Triaged to 9.1.0

  Changed 6 years ago by rejon

  • blocking 3531 added

(In #3531) Yes, agree, http://dev.laptop.org/ticket/3529 is prerequisite for this enhancement.

  Changed 6 years ago by rejon

  • blockedby 7551 added
Note: See TracTickets for help on using tickets.