Opened 7 years ago

Closed 6 years ago

#4084 closed defect (fixed)

Palette persist over zoom levels

Reported by: erikos Owned by: marco
Priority: normal Milestone: 8.2.0 (was Update.2)
Component: sugar Version:
Keywords: joyride-2268:+ sugar-toolkit-0.82.0:+ Cc: benzea, mtd, Eben
Blocked By: Blocking:
Deployments affected: Action Needed: finalize
Verified: no

Description

Steps to reproduce:
1) move mouse over journal icon
2) palette comes up, leave mouse at this position
3) switch to other zoom level
4) palette will still be visible, you can even use it - try to resume journal

This is image 613

Attachments (1)

palette-focused.patch (3.1 KB) - added by benzea 7 years ago.
the broken patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 7 years ago by jg

  • Milestone changed from Never Assigned to First Deployment, V1.0

comment:2 Changed 7 years ago by benzea

  • Cc benzea added

I have played around with this a bit. Now there are two kind of different issues:

  1. The sugar shell, which needs to hide the pallets between zoom changes
  2. Switching between sugar shell and activities

I tried to follow whether one of the toplevel is active (ie. window or palette). This works fine for palettes that cannot be focused (ie. do not contain custom widgets) when switching between application and shell.

I am not sure what one could do about the shell (it needs to be handled inside the shell I expect). As my approach does not even work for palettes that contain custom widgets, it cannot be used for this.

Changed 7 years ago by benzea

the broken patch

comment:3 Changed 7 years ago by benzea

After trying out gtk.Window.set_transient_for on ticket #3611 I noticed that it also solves this ticket when switching between an activity and the shell.

So with that only some special code when changing the zoom level in the shell may be needed.

comment:4 Changed 7 years ago by mtd

  • Cc mtd added

comment:5 Changed 7 years ago by benzea

  • Resolution set to fixed
  • Status changed from new to closed

I have committed a patch to master that hides the palettes when the views are deactiated. ie. it gets the "default" palette group and does a popdown on that.

comment:6 Changed 6 years ago by pgf

  • Action Needed set to never set
  • Resolution fixed deleted
  • Status changed from closed to reopened

i can reproduce this, in both build 708 and joyride 2230.

select network view. hover over a network to bring up the palette. use the function key to return to home view. observe that palette remains visible, until something in the home view with a palette is hovered over.

comment:7 Changed 6 years ago by benzea

The code to pop down all palettes in the "default" palette group is still there, but apparently the "default" palette group does not exist anymore.

I don't know if there is any reason why the default palette group was removed. I think this no only means that the palettes do not disappear, but they will also not pop up immediately when one hovers over the next icon.

comment:8 Changed 6 years ago by benzea

  • Cc Eben added

I just bisected it to figure out where the change was made.

commit 70901268c3b2edb30f01079800a58abac7018721
Author: Eben Eliason <eben@…>
Date: Mon Mar 31 21:27:46 2008 -0400

New palette API


This patch adds support for primary-text, secondary-text,
and icons to palettes. It also transitions a few other items
to a property API.

I guess the call to set_group_id could just be added back again.

comment:9 Changed 6 years ago by benzea

  • Resolution set to fixed
  • Status changed from reopened to closed

Palettes are now again in the "default" palette group by default. This means that the code to popdown the palettes when switching between home/friends/mesh view works again.

comment:10 Changed 6 years ago by erikos

  • Action Needed changed from never set to finalize
  • Keywords joyride-2268:+ sugar-toolkit-0.82.0:+ added
  • Resolution fixed deleted
  • Status changed from closed to reopened

We should not close tickets - we move the 'action-needed' option to 'finalize'. Tested as working in joyride-2268.

comment:11 Changed 6 years ago by gregorio

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.