Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#420 closed defect (fixed)

Keyboard - Arabic.

Reported by: jg Owned by: bernie
Priority: blocker Milestone: 8.2.0 (was Update.2)
Component: keyboards Version:
Keywords: killjoy? Cc: khaled, bernie
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: yes

Attachments (5)

ara-xconf (522 bytes) - added by warp 8 years ago.
Replacement keyboard section for xorg.conf.
ara (1.5 KB) - added by khassounah 8 years ago.
ara.2 (8.7 KB) - added by walter 8 years ago.
B2 version of ARA
ara.diff (2.5 KB) - added by khaled 7 years ago.
Patch to fix brackets and percent sign
ara2.diff (1.9 KB) - added by khaled 7 years ago.
A more recent patchِِِ

Download all attachments as: .zip

Change History (34)

comment:1 follow-ups: Changed 8 years ago by warp

A little different from KH's map, there are a difference or two that he missed, but a few that I missed too.

To switch: DISPLAY=:0 setxkbmap -rules base -model evdev -layout us,ara -variant intl,olpc -option grp:switch

Changed 8 years ago by warp

Replacement keyboard section for xorg.conf.

comment:2 Changed 8 years ago by warp

These were, er, for the Arabic layout. Maybe swap the namings on the bugs?

comment:3 Changed 8 years ago by warp

  • Summary changed from Keyboard - Thai to Keyboard - Arabic.

comment:4 Changed 8 years ago by J5

The ara file change is in build 174. My understanding is that the xorg.conf changes will go into the release notes so we should keep this bug open for now.

comment:5 in reply to: ↑ 1 Changed 8 years ago by khassounah

  • Description modified (diff)

Replying to warp:

A little different from KH's map, there are a difference or two that he missed, but a few that I missed too.

To switch: DISPLAY=:0 setxkbmap -rules base -model evdev -layout us,ara -variant intl,olpc -option grp:switch

comment:6 Changed 8 years ago by khassounah

  • Description modified (diff)

comment:7 in reply to: ↑ 1 Changed 8 years ago by khassounah

Zephaniah,

I have to disagree with almost all of the deltas from my file :)..

Why are the following lines missing the shirt characters? The ones in the original ara base are absolutely right. The braceleft, braceright, colon, and quotedbl are still part of the arabic keybaord:

key <AD11> { [ Arabic_jeem ] };
key <AD12> { [ Arabic_dal ] };
key <AC10> { [ Arabic_kaf ] };
key <AC11> { [ Arabic_tah ] };

The following didn't change from the original base, why are they included in the olpc section? Although I think the confusion in the first is that Arabic_ha and Arabic_heh are different names for the same character:

key <AD08> { [ Arabic_heh, division ] };
key <AB04> { [ Arabic_ra, Arabic_kasratan ] };

If those are removed, we end up with where I started. If those arguments are accepted, and the changes are made to this file, it becomes identical to the one I posted earlier.

comment:8 follow-up: Changed 8 years ago by warp

Specificly, those are indicated to be without a shift state in the documentation that I have.

Either way works though, I suppose.

comment:9 in reply to: ↑ 8 Changed 8 years ago by khassounah

Zephaniah,

If you mean the excel sheet that Walter was putting together, then the convension we followed (at least for arabic) was that we kept the shift status empty for keys that were the same for english and arabic. In hindsight, I can see why that would have been confusing.

I think it make a difference whether they are one way or the other. Not having a colon, or doublt quotes in the arabic keyboard means that the user will have to switch languages everytime they want to type one of those four characters (some are used often).

Khaled

Changed 8 years ago by khassounah

comment:10 Changed 8 years ago by khassounah

  • Description modified (diff)

Latest ara file uploaded based on discussion with Zephaniah

comment:11 Changed 8 years ago by jg

  • Milestone changed from BTest-1 to BTest-1b

I really want the keymaps in B1B.

comment:12 Changed 8 years ago by cjb

  • Resolution set to fixed
  • Status changed from new to closed

comment:13 Changed 8 years ago by walter

Added support for Language key <AB11>

Changed 8 years ago by walter

B2 version of ARA

comment:14 Changed 8 years ago by krstic

  • Milestone changed from BTest-1b to BTest-2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening as per Walter's last comment.

comment:15 Changed 8 years ago by krstic

  • Owner changed from warp to J5
  • Status changed from reopened to new

comment:16 Changed 8 years ago by J5

  • Status changed from new to assigned

should be in build 219

comment:17 Changed 8 years ago by J5

  • Resolution set to fixed
  • Status changed from assigned to closed

in build 221, please reopen if new keymaps are added

comment:18 Changed 7 years ago by khaled

  • Resolution fixed deleted
  • Status changed from closed to reopened

The current keyboard layout isn't working as expected.

One thing is the brackets, with the current layout, right and left brackets doesn't match what the user would expect when typing from right to left. As the user will be reading the keys from right to left, what is now "braceright" will be interpreted as "braceleft" and so, simply we can solve this by reversing the keys with no change to the printed graphics on the keys.

The other issue is the percent sign, the Arabic layout is using Arabic-Indic digits and thus should use Arabic percent sign, this will need printing it on the key.

The attached patch fixes both issues.

Changed 7 years ago by khaled

Patch to fix brackets and percent sign

comment:19 Changed 7 years ago by khaled

  • Cc khaled added

comment:20 Changed 7 years ago by jg

  • Cc bernie added
  • Milestone changed from BTest-2 to Trial-3
  • Status changed from reopened to new

comment:21 Changed 7 years ago by J5

bernie were these put into your package

comment:22 Changed 7 years ago by jg

  • Owner changed from J5 to bernie

Bernie, is this fixed?

comment:23 Changed 7 years ago by bernie

We have an "ara" symbol file, but it is quite different from the original attachment, and I'm afraid I don't know how it came to be so.

The changes in key mappings are consistent, and the ara.diff patch from two months ago would totally not apply. I don't think any of the comments above are relevant any more.

I'd say, let's just close this bug and maybe file a new one for the new layout if we find new problems.

comment:24 follow-up: Changed 7 years ago by jg

Khaled, could you try the current builds and let us know how the layout is now?

comment:25 Changed 7 years ago by jg

  • Milestone changed from Trial-3 to First Deployment, V1.0

comment:26 in reply to: ↑ 24 Changed 7 years ago by khaled

Replying to jg:

Khaled, could you try the current builds and let us know how the layout is now?

I'm testing 593 build, non of the issues mentioned above seems to be fixed, even worse, many keys now doesn't map the expected letter (as printed on my B4 machine) as Arabic keyboard layout has been altered upstream. I'm preparing a new patch as the older one doesn't apply any more.

comment:27 Changed 7 years ago by jg

  • Priority changed from high to blocker

Sigh... Thanks....

Changed 7 years ago by khaled

A more recent patchِِِ

comment:28 Changed 7 years ago by bernie

  • Resolution set to fixed
  • Status changed from new to closed

An updated version of xkeyboard-config including ara2.diff is in joyride.

Thanks!

comment:29 Changed 7 years ago by bernie

  • Keywords killjoy? added
Note: See TracTickets for help on using tickets.