Ticket #4241 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Salut MUC stream tubes close before they should

Reported by: gdesmott Owned by: smcv
Priority: high Milestone: Update.1
Component: telepathy-salut Version:
Keywords: Update.1? collaboration Cc: sjoerd, smcv, daf
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Salut should support muc stream tubes as Gabble does.

Change History

Changed 7 years ago by daf

This will let us port Read etc. to tubes, and have them work both on the mesh and with the server. (The server part works; this is about making the mesh part work.)

Changed 7 years ago by smcv

  • priority changed from normal to high

Changed 6 years ago by gdesmott

  • keywords collaboration, review? added; collaboration removed

Muc stream tubes are now implemented in http://projects.collabora.co.uk/~monkey/telepathy-salut-tubes/

Waiting for -new-protocol merge and final review.

Changed 6 years ago by smcv

  • owner changed from gdesmott to smcv
  • status changed from new to assigned

Fixed in snapshot 20071026, in jhbuild and the next Joyride image (should be 107 if all goes well).

My stream-tubes patch to Read doesn't work with Salut, but I think that's because of a bad assumption in sugar.network, about which I'll file a separate bug.

Changed 6 years ago by smcv

  • keywords collaboration review+ fixed added; collaboration, review? removed

Changed 6 years ago by kimquirk

  • keywords killjoy?, added

Changed 6 years ago by gdesmott

This change is already available for testing in joyride.

Changed 6 years ago by smcv

  • keywords killjoy? Update.1? just-dont-know? added; killjoy?, removed

Changed 6 years ago by smcv

  • milestone changed from Update.2 to Update.1

Changed 6 years ago by kimquirk

  • keywords killjoy? removed

Changed 6 years ago by smcv

  • keywords just-dont-know? review+ fixed removed
  • summary changed from Salut doesn't implement muc stream tubes to Salut MUC stream tubes might not work reliably

I'm not closing this one just yet because my patched Read activity (#4297) doesn't work with Salut. It's unclear whose fault this is - it could be any of Salut, sugar.network (#4505) or Read. Guillaume is simplifying the stream-tubes code to use Gibber transports instead of re-inventing them, on the basis that less code means fewer bugs; once that's done we'll re-test the code from #4297 and see if the incomplete download problem has gone away.

Changed 6 years ago by smcv

  • status changed from assigned to closed
  • resolution set to fixed
  • summary changed from Salut MUC stream tubes might not work reliably to Salut MUC stream tubes close before they should

Fixed in jhbuild and Koji, snapshot 0.1.5.1-olpc20071102, should be in Joyride 210.

Note: See TracTickets for help on using tickets.