Opened 7 years ago

Closed 7 years ago

#4241 closed defect (fixed)

Salut MUC stream tubes close before they should

Reported by: gdesmott Owned by: smcv
Priority: high Milestone: Update.1
Component: telepathy-salut Version:
Keywords: Update.1? collaboration Cc: sjoerd, smcv, daf
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

Salut should support muc stream tubes as Gabble does.

Change History (12)

comment:1 Changed 7 years ago by daf

This will let us port Read etc. to tubes, and have them work both on the mesh and with the server. (The server part works; this is about making the mesh part work.)

comment:2 Changed 7 years ago by smcv

  • Priority changed from normal to high

comment:3 Changed 7 years ago by gdesmott

  • Keywords review? added

Muc stream tubes are now implemented in http://projects.collabora.co.uk/~monkey/telepathy-salut-tubes/

Waiting for -new-protocol merge and final review.

comment:4 Changed 7 years ago by smcv

  • Owner changed from gdesmott to smcv
  • Status changed from new to assigned

Fixed in snapshot 20071026, in jhbuild and the next Joyride image (should be 107 if all goes well).

My stream-tubes patch to Read doesn't work with Salut, but I think that's because of a bad assumption in sugar.network, about which I'll file a separate bug.

comment:5 Changed 7 years ago by smcv

  • Keywords review+ fixed added; review? removed

comment:6 Changed 7 years ago by kimquirk

  • Keywords killjoy? added

comment:7 Changed 7 years ago by gdesmott

This change is already available for testing in joyride.

comment:8 Changed 7 years ago by smcv

  • Keywords Update.1? just-dont-know? added

comment:9 Changed 7 years ago by smcv

  • Milestone changed from Update.2 to Update.1

comment:10 Changed 7 years ago by kimquirk

  • Keywords killjoy? removed

comment:11 Changed 7 years ago by smcv

  • Keywords just-dont-know? review+ fixed removed
  • Summary changed from Salut doesn't implement muc stream tubes to Salut MUC stream tubes might not work reliably

I'm not closing this one just yet because my patched Read activity (#4297) doesn't work with Salut. It's unclear whose fault this is - it could be any of Salut, sugar.network (#4505) or Read. Guillaume is simplifying the stream-tubes code to use Gibber transports instead of re-inventing them, on the basis that less code means fewer bugs; once that's done we'll re-test the code from #4297 and see if the incomplete download problem has gone away.

comment:12 Changed 7 years ago by smcv

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Summary changed from Salut MUC stream tubes might not work reliably to Salut MUC stream tubes close before they should

Fixed in jhbuild and Koji, snapshot 0.1.5.1-olpc20071102, should be in Joyride 210.

Note: See TracTickets for help on using tickets.