Opened 7 years ago

Last modified 6 years ago

#4494 new defect

activities don't successfully launch if pservice.get_preferred_connection fails in init

Reported by: erikb Owned by: morgs
Priority: normal Milestone: 9.1.0-cancelled
Component: presence-service Version: Development build as of this date
Keywords: 9.1.0:+ Cc: olpc-dev@…, olpc@…, eben
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

see attached log.

on: b622

behavior: grey screen.

analysis: in trying to debug this, it looks like when this call fails, a shutdown sequence is called somewhere... but it never successfully closes the activity.

workaround: restart sugar

Attachments (5)

org.laptop.RecordActivity.log (2.4 KB) - added by erikb 7 years ago.
org.laptop.RecordActivity.log
presenceservice.log (13.6 KB) - added by erikb 7 years ago.
ps.log of linklocal
org.laptop.RecordActivity.2.log (4.1 KB) - added by erikb 7 years ago.
record.log of linklocal error
telepathy-gabble.log.1193683636 (6.8 KB) - added by erikb 7 years ago.
gabble.log of linklocal error
telepathy-salut.log.1193683636 (901.4 KB) - added by erikb 7 years ago.
salut.log of linklocal error

Download all attachments as: .zip

Change History (18)

Changed 7 years ago by erikb

org.laptop.RecordActivity.log

comment:1 Changed 7 years ago by erikb

  • Cc olpc-dev@… added

comment:2 Changed 7 years ago by erikb

  • Owner changed from jg to smcv

steps to reproduce on b622: share link local, buddy join, both quit. on re-launch of activity i get this error. see the attached ps and record logs.

Changed 7 years ago by erikb

ps.log of linklocal

Changed 7 years ago by erikb

record.log of linklocal error

Changed 7 years ago by erikb

gabble.log of linklocal error

Changed 7 years ago by erikb

salut.log of linklocal error

comment:3 Changed 7 years ago by smcv

The failure was caused by #4500. Most (all?) activities shouldn't actually need to call get_preferred_connection().

comment:4 Changed 7 years ago by jg

  • Milestone changed from Untriaged to Future Release

Will consider a simple fix for Update.1.

comment:5 Changed 7 years ago by mcfletch

#4883 would seem to be a related issue, there the same function is returning None (instead of just failing). There are definitely activities that call the function. Every OLPCGames activity, for one.

comment:6 Changed 7 years ago by smcv

  • Cc olpc@… added
  • Owner changed from smcv to morgs

Reassigning to morgs, Cc the Collabora OLPC team, since I'm not currently working on OLPC.

comment:7 Changed 7 years ago by daf

  • Component changed from presence-service to camera-activity

Activities shouldn't use this function any more.

This is the patch to Hello Mesh to stop it from using it:

http://dev.laptop.org/git?p=projects/hellomesh;a=commitdiff;h=723ba547e4d7fe7ccca856b264b10cd9fdd291e6

comment:8 Changed 7 years ago by daf

  • Component changed from camera-activity to presence-service

Seems I was a bit rash. Morgan points out that this function might return None if we are waiting for Gabble to connect. Seems we need to improve the PS API to expose the fact that there isn't always a connection that can be used for sharing, and notifying activities when a connection becomes available or disappears. Handling this correctly in activities might turn out to be a pain.

See also #4404.

comment:9 Changed 7 years ago by daf

There is also a UI question of disabling the share button while there is no available connection.

comment:10 follow-up: Changed 7 years ago by erikb

  • Cc eben added

Collabora - Is this something that you recommend fixing for update.1?

Eben - Please take a look at this thread and consider the ui implications. Once this bug is fixed in Record, I will push this trac item to you.

comment:11 Changed 7 years ago by daf

It might be risky to change this for Update 1. I suppose we should think up a suitable API and consider how invasive it would be to implement it. Morgan: any thoughts?

comment:12 in reply to: ↑ 10 Changed 7 years ago by morgs

Replying to erikb:

Collabora - Is this something that you recommend fixing for update.1?

Discussing this now in a thread on devel. I don't think the fix is invasive, but we've either got to fix all the activities or not bother.

Prepare to fix soon though: See http://dev.laptop.org/git?p=projects/hellomesh;a=commitdiff;h=e6c15f7c77914bf8c30a119786413685ef19e30b for the fix for HelloMesh, and take a look at the current HelloMesh code. (There might have been more than one patch that was relevant.)

comment:13 Changed 6 years ago by marco

  • Keywords 9.1.0:+ added
  • Milestone changed from Future Release to 9.1.0
Note: See TracTickets for help on using tickets.