Opened 9 years ago

Closed 9 years ago

#4741 closed defect (fixed)

Should be ported to use stream tubes

Reported by: gdesmott Owned by: bemasc
Priority: normal Milestone: 8.2.0 (was Update.2)
Component: acoustic-measure-activity Version:
Keywords: Cc: smcv, morgs
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no


As Read (#4297), the acoustic measure activity should be ported to use stream tubes and so get rid of its weird socket emulation.

Change History (7)

comment:1 Changed 9 years ago by bemasc

This is undeniably true. However, I have been told that stream tubes are not ready for Update.1 (esp. salut), so I have postponed work on this. If Streams are now ready, I will be happy to look through the Read code and update this activity.

comment:2 Changed 9 years ago by gdesmott

Yeah, you can now use stream tubes with Salut but only in a muc context (not really a problem as we always use a muc when sharing an activity)

comment:3 Changed 9 years ago by jg

  • Milestone changed from Never Assigned to Update.1

If tubes is already working in an application, I'd like to delay updating to the new interface until after Update.1.... If an application needs to have a bug fixed in the tubes area, then I'm ok with updating to the new interface.

It sounds like this application still needs updating to use tubes; if so, please use the new interface.

comment:4 Changed 9 years ago by bemasc

jg: Acoustic Tape Measure already has a completely functional, well-tested Tubes implementation. It uses DBus Tubes. gdesmott is proposing to convert it to Stream tubes. With only one xo, it is hard to debug Tubes problems, so I have been avoiding rewriting until I have two xo's to test with.

I don't think Update.1 is a good milestone for this.

comment:5 Changed 9 years ago by bemasc

  • Milestone changed from Update.1 to Update.2

comment:6 Changed 9 years ago by bemasc

This change is now done, tested, and working far better than the previous code. It's also dramatically simpler. However, it doesn't work over Salut, due to #5204. Once #5204 is fixed, I will submit these changes immediately.

comment:7 Changed 9 years ago by bemasc

  • Resolution set to fixed
  • Status changed from new to closed

Implemented in v9. Not working anymore due to telepathy-salut bug #5445, but that's a separate issue with a known solution.

Note: See TracTickets for help on using tickets.