Browse view source doesn't work

[kimquirk]

build 262

Open browse; goto a webpage; hit fn-space. It is supposed to open abiword and show the html.

It doesn't do anything in this build.

[erikos]

Ok the entry in the journal gets stored correctly. With rainbow deactivated write gets launched fine. The problem is that rainbow prohibits the launching of activities from within another activity. At the moment we do:

activityfactory.create_with_object_id(service_name, id)

As a sidenote you can launch write from within browse when rainbow is turned on when you use sugar-launch web from within the terminal.

[erikos]

Ok in 261 the fn+space keystroke seems to be broken.

[marco]

I'll keep this ticket for the browse activity specific issues (fn+space for example). I'll open another one about the rainbow issue.

[marco]

Simon, we need this working well without security as soon as possible, so that we can actually test and solve the security problems. #4909 is about the security issues.

[marco]

Noticed we can use ctrl+u for testing while fn+space is fixed.

[mstone]

See #4909 for my thoughts on the use case underlying this bug.

[erikos]

This patch will adopt to the fn+space changes.

diff --git a/webactivity.py b/webactivity.py
index 123e28d..8b47008 100755
--- a/webactivity.py
+++ b/webactivity.py
@@ -58,7 +58,6 @@ SERVICE = "org.laptop.WebActivity"
 IFACE = SERVICE
 PATH = "/org/laptop/WebActivity"
 
-_VIEW_SOURCE_KEY_CODE = 0x1008FF1A
 _TOOLBAR_BROWSE = 1
 
 _logger = logging.getLogger('web-activity')
@@ -315,7 +314,7 @@ class WebActivity(activity.Activity):
                 _logger.debug('keyboard: Zoom in')
                 self._browser.zoom_in()
                 return True
-        elif event.keyval == _VIEW_SOURCE_KEY_CODE:
+        elif gtk.gdk.keyval_name(event.keyval) == "XF86Start":
             _logger.debug('keyboard: Show source of the current page SHOW_KEY')
             self._show_source()
             return True

[marco]

Simon, I think Jim is generally requiring to get stuff in joyride for testing before giving approval (the patch is really simple here though...)

[erikos]

Has been tested and works in joyride.

[jg]

Simon, you don't indicate what package is updated in joyride...

[marco]

Please push Web-76.xo

[marco]

Ignore my previous comment, sorry.

[erikos]

I have made another bundle for update.1: Web-77.xo which is in my public rpm folder.

[erikos]

assign to me for testing

[erikos]

I tested the fn+space in the 1416 and it works fine. Web-77.xo

[marco]

What's up here? Should we request approval?

[erikos]

Tested in 661 as working.

[danielfuhry]

It's not working in 691 (update.1) instead the activity details from journal are displayed.

[erikos]

This is the intended behavior: http://wiki.laptop.org/go/Browse#View_Source What you are seeing is correct.