PS doesn't try to reconnect Gabble if initial connect attempt failed

[gdesmott]

To reproduce: - edit your ~/.sugar/default/config and set an unexisting jabber server - Launch sugar. Gabble can't connect to its server - After 5 seconds, the timer is activated but start() won't try to reconnect because self._conn is not None

[smcv]

11:41 < smcv> cassidy: change the second part to "if not dbus_name and 
              self._conn is not None", otherwise +1
11:42 < smcv> cassidy: (with dbus_name we're testing for e.g. ":1.9" vs "", so 
              a truth test is what we want - but when comparing to None, always 
              use "is [not] None" because it's more efficient and is what you 
              actually mean)

However, the 5 second retry frequency is likely to flood the network, so this bug shouldn't be fixed until #2522 also is (fixing both of them in the same PS release would be ideal).

[gdesmott]

Now #2522 was fixed and approved for Update.1, what about this fix?

[jg]

Is this in Joyride? If not, please put it there and test it for update.1.

Once tested in Joyride, reassign to Approval for update.....

[robot101]

It's in Joyride since 0.27.20071114git128c59c612 and has been tested. That one release had four fixes in, for #4936, #4896, #2522 and this bug. It just needs tagging for Update.1.

[jg]

this is believed included in update.1 build 637, please verify that it is fixed and then close this bug.

[gdesmott]

Seems ok in update1-639