Opened 7 years ago

Closed 7 years ago

#5018 closed task (fixed)

reduce gabble's stanza size for IBB packets

Reported by: robot101 Owned by: dgilmore
Priority: normal Milestone: Update.1
Component: telepathy-gabble Version:
Keywords: review+ Cc: gdesmott, daf, jg, smcv, kimquirk, morgs
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

Ejabberd has a default maximum stanza size of 64k, but gabble (IIRC) assumes 256k packets are acceptable. This should be lowered to aid interoperability with real-world Jabber servers without the same hacks that jabber.laptop.org has (now) got. See #4108 for details.

Attachments (1)

lower-muc-tubes-max-stanza-size.patch (684 bytes) - added by robot101 7 years ago.
proposed patch

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by robot101

proposed patch

comment:1 Changed 7 years ago by robot101

  • Cc kimquirk added
  • Owner changed from gdesmott to robot101
  • Status changed from new to assigned

I've added a proposed patch, on the basis that base64 produces 4 bytes of output for 3 bytes of input, it adds a 33% overhead. The maximum stanza size is 64k in ejabberd by default, so I've set the input block size to 45k, which will yield a maximum of 60k after base64 encoding, and allow 4k for the XML encapsulation.

comment:2 Changed 7 years ago by jg

  • Keywords Update.1? removed
  • Milestone changed from Never Assigned to Update.1

OK for update.1.

comment:3 Changed 7 years ago by gdesmott

  • Keywords review+ added

+1 for the patch

comment:4 Changed 7 years ago by robot101

  • Owner changed from robot101 to morgs
  • Status changed from assigned to new

I've pushed telepathy-gabble-0.7.1-0.6.olpc2 with this patch into koji, should appear in Joyride soon. Morgs, can you check activity sharing works OK with this package then assign to dgilmore for inclusion in Update.1 (given the patch is already approved).

comment:5 Changed 7 years ago by morgs

  • Owner changed from morgs to ApprovalForUpdate

Tested telepathy-gabble-0.7.1-0.6.olpc2 in joyride using write and inserting a picture - works. I see this is triaged to Update.1 but I don't see approval for Update.1, so assigning to ApprovalForUpdate.

Build engineer can assign it back to morgs when it's in Update.1 for testing.

comment:6 Changed 7 years ago by morgs

  • Owner changed from ApprovalForUpdate to dgilmore

comment:7 Changed 7 years ago by morgs

  • Cc morgs added

comment:8 Changed 7 years ago by gdesmott

Please tag telepathy-gabble 0.7.1-0.6.olpc2 or higher for Update.1 so we can close this bug.

comment:9 Changed 7 years ago by gdesmott

  • Resolution set to fixed
  • Status changed from new to closed

telepathy-gabble-0.7.1-0.7.olpc2 is now in Update.1.

Tested and worked fine with build 658

Note: See TracTickets for help on using tickets.