Opened 7 years ago

Closed 7 years ago

#5223 closed defect (fixed)

Should ignore echoed pubsub notifications

Reported by: gdesmott Owned by: dgilmore
Priority: normal Milestone: Update.1
Component: telepathy-gabble Version:
Keywords: review+ Cc: smcv, daf, robot101, gdesmott
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

While testing sugar using openfire as Jabber server, I noticed Gabble was confused by echoed pubsub notifications making shared activities not appearing on the mesh view.
Ejabberd doesn't send these notifications so we didn't notice this before (seems it's an ejabberd bug according to XEP-0163).

Attached a patch (already reviewed and merged upstream) fixing that. I think we should ship it to make sharing work with openfire and avoid regressions if we upgrade our ejabberd server to a version which does send these notifications.

Attachments (1)

gabble-pep-notifications.patch (1.6 KB) - added by gdesmott 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by gdesmott

comment:1 Changed 7 years ago by gdesmott

Note that with this patch and the fix of #5224, I can share and play Connect using openfire as server.

comment:2 Changed 7 years ago by jg

  • Milestone changed from Never Assigned to Update.1

Please get this into joyride ASAP for some soaking before it (hopefully) can go into Update.1...

comment:3 Changed 7 years ago by jg

  • Cc gdesmott added

Again, we need to know what needs to be updated.

comment:4 Changed 7 years ago by gdesmott

This patch fix reached Joyride in telepathy-gabble-0.7.1-0.5.olpc2.i386.rpm.
See http://koji.fedoraproject.org/koji/buildinfo?buildID=26876

comment:5 Changed 7 years ago by jg

  • Owner changed from ApprovalForUpdate to dgilmore

Approved.

comment:6 Changed 7 years ago by gdesmott

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in telepathy-gabble-0.7.1-0.5.olpc2.i386.rpm which is tagged for Update.1

Note: See TracTickets for help on using tickets.