Ticket #5224 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Properly handle multi values muc settings

Reported by: gdesmott Owned by: dgilmore
Priority: normal Milestone: Update.1
Component: telepathy-gabble Version:
Keywords: review? Cc: daf, smcv, robot101, gdesmott
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

While testing activity sharing using openfire I noticed Gabble didn't properly manage multi values in muc settings. This breaks D-Bus tubes when sharing an activity because the muc presence isn't broadcasted to muc participants.

This bug doesn't affect ejabberd as it doesn't use this muc setting but could cause regressions in the futur if we upgrade to a version using it.

Attached a patch (already reviewed and merged upstream) fixing multi values settings in muc properties.

Attachments

gabble-muc-properties.patch (4.9 kB) - added by gdesmott 7 years ago.

Change History

Changed 7 years ago by gdesmott

Changed 7 years ago by gdesmott

Note that with this patch and the fix of #5223, I can share and play Connect using openfire as server.

Changed 7 years ago by jg

  • milestone changed from Never Assigned to Update.1

Ugh... Not happy about the size of this patch...

Please get this into joyride ASAP for testing. After some days of soak, I'll consider update.1 if it holds up...

Changed 7 years ago by jg

  • cc gdesmott added

Again, we need to know what is being updated...

Changed 7 years ago by daf

I made a Gabble release with the patches for #5223 and this bug included:

http://koji.fedoraproject.org/koji/buildinfo?buildID=26876

Changed 7 years ago by jg

  • owner changed from ApprovalForUpdate to dgilmore

Approved.

Changed 7 years ago by gdesmott

  • status changed from new to closed
  • resolution set to fixed

Fixed in telepathy-gabble-0.7.1-0.5.olpc2.i386.rpm which is tagged for Update.1

Note: See TracTickets for help on using tickets.