Ticket #5269 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

Browser Identification is not descriptive

Reported by: QuantumG Owned by: marco
Priority: normal Milestone: Update.1
Component: browse-activity Version:
Keywords: browser, identification, HTTP_USER_AGENT Cc: erikos
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

HTTP_USER_AGENT for Browse activity should include the string "OLPC" and perhaps the OS build and laptop version, etc.

This will aid web developers to layout content appropriately and provide a good browser statistic metric.

Attachments

hulahop-prefs.diff (466 bytes) - added by QuantumG 7 years ago.

Change History

Changed 7 years ago by QuantumG

This can be done by adding the following to /usr/share/hulahop/prefs.js

pref("general.useragent.vendor", "OLPC"); pref("general.useragent.vendorSub", "1.1"); pref("general.useragent.vendorComment", "XO2");

and I also notice that the locale currently isn't set, so:

pref(general.useragent.locale", "en-US");

for example, otherwise you send the unhelpful string of "chrome://navigator/locale/navigator.properties" for locale.

Changed 7 years ago by QuantumG

Changed 7 years ago by QuantumG

Here's a patch.

Changed 7 years ago by jg

  • milestone changed from Never Assigned to Update.1

Changed 7 years ago by erikos

Thanks QuantumG works great will add it to the hulahop package.

Changed 7 years ago by erikos

  • cc erikos added
  • owner changed from erikos to ApprovalForUpdate

Tested in joyride 1416.

Way to verify: document.write(navigator.userAgent))

Who verifies in update.1: erikos

The package that needs to go into update.1 for this fix is: hulahop-0.4.0-1.olpc2

Changed 7 years ago by jg

  • owner changed from ApprovalForUpdate to dgilmore

Approved.

Changed 7 years ago by marco

This is not in the build yet, please get it in as soon as possible.

Changed 7 years ago by dgilmore

  • owner changed from dgilmore to marco

please test build 661

Changed 7 years ago by erikos

  • status changed from new to closed
  • resolution set to fixed

Tested as working fine in 661.

Note: See TracTickets for help on using tickets.