Ticket #5323 (new defect)

Opened 7 years ago

Last modified 2 years ago

browser upload from gnash bypasses Journal.

Reported by: walter Owned by: erikos
Priority: low Milestone: Future Release
Component: browse-activity Version:
Keywords: Cc: tomeu, marco, rsavoye
Action Needed: never set Verified: no
Deployments affected: Blocked By:
Blocking:

Description

I went to upload a .ogg file and ended up in a file dialog instead of selecting from the Journal. This seems to be a regression of some sort in the browser.

To reproduce the bug on Ship.2,

Record a video with the Record Activity Goto www.fliggo.com Try uploading your video

Change History

  Changed 7 years ago by walter

Trying to upload to our wiki crashed the browser--never got an upload dialog.

  Changed 7 years ago by walter

the later upload problem seemed to be journal related...

  Changed 7 years ago by walter

From the Fliggo guys:

We are using flash as our uploader. We're using a library called FileReference provided by Macromedia. I believe it's native action is to open a file browser. On windwos and mac as well it opens up the native file browser over anything else you have.

Hope this helps. Keep up the great work.

-- Chrys Bader Co-Founder Fliggo - For Your Video | www.fliggo.com

  Changed 7 years ago by jg

  • milestone changed from Never Assigned to Update.1

follow-up: ↓ 7   Changed 7 years ago by walter

If this is Flash-related, which is seems to be, we may only be able to fix it in Gnash.

  Changed 7 years ago by erikos

  • owner changed from simon to erikos

in reply to: ↑ 5   Changed 7 years ago by tomeu

  • cc tomeu added

Replying to walter:

If this is Flash-related, which is seems to be, we may only be able to fix it in Gnash.

When Browse is moved to run inside Rainbow, it won't be allowed to access the full filesystem.

For the right fix, the FileReference class in Gnash or Adobe's implementation should make use of the object chooser in the Journal.

follow-up: ↓ 9   Changed 7 years ago by walter

For the right fix, the FileReference? class in Gnash or Adobe's implementation should make use of the object chooser in the Journal.

Should, but apparently it doesn't. Is this something we can fix outside of Flash/Gnash or it something they have to fix for us?

in reply to: ↑ 8   Changed 7 years ago by tomeu

  • cc marco added

Replying to walter:

For the right fix, the FileReference? class in Gnash or Adobe's implementation should make use of the object chooser in the Journal.

Should, but apparently it doesn't. Is this something we can fix outside of Flash/Gnash or it something they have to fix for us?

The flash libraries in both Gnash and Adobe's Flash need to be adapted to our system. That would imply for Adobe to create a new version of their implementation targeted to Sugar similarly to the ones they already have for OSX, Windows and (conventional) Linux.

Alternatively, I think the linux implementation of Adobe's Flash uses gtk for the file chooser dialog. In principle, we could patch gtk to use our object chooser in the journal across DBus. I'm not sure this would work or is a good idea, though.

  Changed 7 years ago by marco

It *might* work. The gtk file picker has abstract interfaces to allow implementing custom UI. We should investigate if it's possible to write an implementation which uses out object chooser. (For the record this is likely to be a lot of work).

  Changed 7 years ago by marco

Custom UI and different file system backends too, I think.

follow-up: ↓ 14   Changed 7 years ago by kimquirk

  • priority changed from high to blocker

My browser crashes (build 605) trying to open or read the journal when I click on 'attach' a file to an email (using gmail). Is this the same bug or should I write up a new one? If so, this is a blocker.

  Changed 7 years ago by walter

Is this a typo? Did you mean Build 650?

in reply to: ↑ 12   Changed 7 years ago by tomeu

Replying to kimquirk:

My browser crashes (build 605) trying to open or read the journal when I click on 'attach' a file to an email (using gmail). Is this the same bug or should I write up a new one? If so, this is a blocker.

This ticket refers to a different issue: have Flash plugins use the journal dialog instead of a file chooser.

Your upload troubles are tracked in #5106, we already have a fix for this in joyride.

  Changed 7 years ago by marco

  • milestone changed from Update.1 to Retriage, Please!

  Changed 7 years ago by marco

Is this really a major issue given that it applies only to flash?

  Changed 7 years ago by walter

I don't consider this a blocker. Not sure we can do anything about it directly anyway. It would be worth bringing to Rob's attention so that we can be sure that Gnash works properly, in any case.

  Changed 7 years ago by jg

  • cc rsavoye added
  • milestone changed from Retriage, Please! to Update.2

  Changed 7 years ago by rsavoye

Gnash doesn't have a file chooser box at all, so I'm not sure if this is a problem. I've been adding one, but it's unfinished, and not even checked in yet. When I do finish it up. I was planning on using the GTK FileChooser, but maybe now I'll do something different. I imagine the browser may not like the way Gnash handles this Adobe supplied class in some way. If you can supply a test case, or the file that's causing this problem, and I'll see about tracking this down, and then making Gnash do the right thing.

  Changed 7 years ago by walter

Test case from the original post:

Goto www.fliggo.com and try uploading a video. The dialog box bypasses the Journal and goes directly to the file system.

  Changed 6 years ago by cscott

  • priority changed from blocker to high
  • milestone changed from 8.2.0 (was Update.2) to Future Release
  • next_action set to never set
  • summary changed from browser upload not using Journal on Ship.2 to browser upload from gnash bypasses Journal.

On joyride-2097, went to fliggo.com and logged in w/ username 'wrtetwp' password 'abcdefg' and clicked the 'upload file' button. Nothing happened (which supports rsavoye's claim). Perhaps Adobe's plugin does something different?

We should continue to work with gnash upstream to make gnash "do the right thing".

  Changed 2 years ago by godiard

  • priority changed from high to low
Note: See TracTickets for help on using tickets.