Ticket #5415 (new defect)

Opened 7 years ago

Last modified 6 years ago

Libraries are not found in lib dir of bundle

Reported by: bert Owned by: mstone
Priority: normal Milestone: 9.1.0-cancelled
Component: sugar Version:
Keywords: 9.1.0:? review+ Cc: mstone, marco
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

The "lib/" subdirectory of a bundle should be added to the default library search path of an activity.

Not sure what the best way is for that, but adding "$SUGAR_BUNDLE_PATH/lib" to LD_LIBRARY_PATH should work.

Attachments

Change History

Changed 7 years ago by jg

  • milestone changed from Never Assigned to Future Release

Changed 7 years ago by jg

  • cc mstone added
  • keywords rainbow-integration added

Changed 7 years ago by mstone

Sugar's activityfactory.py creates an environment dictionary that Rainbow eventually uses to start up the activity instance. For the time being, sugar should simply modify LD_LIBRARY_PATH in that dictionary just like it already modifies PATH.

Changed 7 years ago by jg

  • keywords Update.1? removed
  • milestone changed from Future Release to Update.1

Changed 7 years ago by mstone

  • owner changed from marco to mstone

Changed 7 years ago by marco

  • milestone changed from Update.1 to Retriage, Please!

I don't think it's necessary to do this for Update.1. The sooner it goes in git the better though, so that activities can rely on it for Update.2.

Changed 7 years ago by mstone

  • cc marco added
  • keywords review? added; rainbow-integration removed

Marco, I think the above patch might do the trick. Care to take a look?

Changed 7 years ago by jg

  • milestone changed from Retriage, Please! to Update.2

Changed 6 years ago by marco

  • keywords review- added; review? removed

We cannot assume LD_LIBRARY_PATH is set.

Changed 6 years ago by mstone

  • keywords review? added; review- removed

Good point. The list comprehension in my second attempt should fix that problem.

Changed 6 years ago by marco

  • keywords review+ added; review? removed

The style guide dictate 79 columns. review+ with that fixed.

http://wiki.laptop.org/go/Python_Style_Guide

Changed 6 years ago by marco

Michael, did you land this one?

Changed 6 years ago by mstone

No, I dropped it. :(

Changed 6 years ago by marco

  • keywords 9.1.0:? added
  • milestone changed from 8.2.0 (was Update.2) to 9.1.0
Note: See TracTickets for help on using tickets.