Opened 7 years ago

Last modified 6 years ago

#5415 new defect

Libraries are not found in lib dir of bundle

Reported by: bert Owned by: mstone
Priority: normal Milestone: 9.1.0-cancelled
Component: sugar Version:
Keywords: 9.1.0:? review+ Cc: mstone, marco
Blocked By: Blocking:
Deployments affected: Action Needed:
Verified: no

Description

The "lib/" subdirectory of a bundle should be added to the default library search path of an activity.

Not sure what the best way is for that, but adding "$SUGAR_BUNDLE_PATH/lib" to LD_LIBRARY_PATH should work.

Attachments (2)

Change History (16)

comment:1 Changed 7 years ago by jg

  • Milestone changed from Never Assigned to Future Release

comment:2 Changed 7 years ago by jg

  • Cc mstone added
  • Keywords rainbow-integration added

comment:3 Changed 7 years ago by mstone

Sugar's activityfactory.py creates an environment dictionary that Rainbow eventually uses to start up the activity instance. For the time being, sugar should simply modify LD_LIBRARY_PATH in that dictionary just like it already modifies PATH.

comment:4 Changed 7 years ago by jg

  • Keywords Update.1? removed
  • Milestone changed from Future Release to Update.1

comment:5 Changed 7 years ago by mstone

  • Owner changed from marco to mstone

comment:6 Changed 7 years ago by marco

  • Milestone changed from Update.1 to Retriage, Please!

I don't think it's necessary to do this for Update.1. The sooner it goes in git the better though, so that activities can rely on it for Update.2.

comment:7 Changed 7 years ago by mstone

  • Cc marco added
  • Keywords review? added; rainbow-integration removed

Marco, I think the above patch might do the trick. Care to take a look?

comment:8 Changed 7 years ago by jg

  • Milestone changed from Retriage, Please! to Update.2

comment:9 Changed 7 years ago by marco

  • Keywords review- added; review? removed

We cannot assume LD_LIBRARY_PATH is set.

comment:10 Changed 7 years ago by mstone

  • Keywords review? added; review- removed

Good point. The list comprehension in my second attempt should fix that problem.

comment:11 Changed 7 years ago by marco

  • Keywords review+ added; review? removed

The style guide dictate 79 columns. review+ with that fixed.

http://wiki.laptop.org/go/Python_Style_Guide

comment:12 Changed 6 years ago by marco

Michael, did you land this one?

comment:13 Changed 6 years ago by mstone

No, I dropped it. :(

comment:14 Changed 6 years ago by marco

  • Keywords 9.1.0:? added
  • Milestone changed from 8.2.0 (was Update.2) to 9.1.0
Note: See TracTickets for help on using tickets.