Opened 7 years ago

Last modified 6 years ago

#5470 new defect

importing telepathy is slow

Reported by: tomeu Owned by: Collabora
Priority: normal Milestone: Opportunity
Component: telepathy-other Version:
Keywords: 8.2.0:- 9.1.0:? Cc:
Blocked By: Blocking:
Deployments affected: Action Needed: diagnose
Verified: no

Description

Takes 12.5% of the total startup time of a minimal activity. See #5228 for more details and a profile.

Perhaps we should discuss it for update.1, as could be low hanging fruit that could help significantly activity startup.

Attachments (1)

imports3.log (4.4 KB) - added by tomeu 7 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by jg

  • Keywords update.1? removed
  • Milestone changed from Never Assigned to Update.1

comment:2 Changed 7 years ago by gdesmott

  • Cc gdesmott added

comment:3 Changed 7 years ago by morgs

  • Cc morgs added

comment:4 Changed 7 years ago by smcv

  • Cc olpc@… added; gdesmott morgs removed
  • Owner changed from smcv to morgs

Reassigning to morgs, Cc the Collabora OLPC team, since I'm not currently working on OLPC.

comment:5 Changed 7 years ago by mtd

takes 13 seconds to import telepathy (see http://dev.laptop.org/ticket/5228#comment:32 #5228 comment) in update.1 690.

comment:6 Changed 7 years ago by mtd

1.3 seconds, sorry.

comment:7 Changed 7 years ago by morgs

  • Cc olpc@… removed
  • Owner changed from morgs to Collabora

comment:8 Changed 7 years ago by tomeu

Take in account that these 1.3 seconds is not what it takes to an activity to import telepathy, as it includes the import of several modules that need to be imported anyway.

So, the right way of calculating the impact of one import is to see which other modules it imports and subtract the time taken by those modules that need to be imported from other parts of the activity.

Attached is a file with all the modules imported by a very simple activity, taken with 'python -v sugar-launch <activity name>'.

If we wanted to know how much impact has the telepathy module in activity startup, we would need to move the imports caused by 'import telepathy' to the end, and time those.

Changed 7 years ago by tomeu

comment:9 Changed 6 years ago by mstone

  • Action Needed set to diagnose
  • Keywords 8.2.0:- 9.1.0:? added
  • Milestone changed from 8.2.0 (was Update.2) to Opportunity

This is does not need to be fixed in 8.2.0 because the the rainbow module importing hack masks the performance problem.

Note: See TracTickets for help on using tickets.