Ticket #5487 (closed defect: fixed)

Opened 7 months ago

Last modified 6 months ago

XUL modal dialogs are not supported

Reported by: kevinprt Owned by: erikos
Priority: blocker Milestone: Update.1
Component: browse-activity Version: Build 650
Keywords: Gmail Hotmail popups alerts review? Cc: tomeu, erikos, marco
Action Needed: Verified: no
Blocked By: Blocking: #5534

Description

Gmail has an alert if send button is pushed and subject line is empty. XO doesn't show the alert (popup), therefore it fails to send. The reason is not apparent to the user.

Similiar problem in hotmail when managing folders. Deleting a folder normally shows an alert, however it doesn't appear when using XO. Not apparent to user, so it doesn't delete folder.

Attachments

xuldialogs.patch (1.9 kB) - added by marco 7 months ago.

Change History

Changed 7 months ago by tomeu

  • cc tomeu added

If the missing popups are really alerts (javascript alert() or confirm()), then we need to first add support for modal alerts in sugar and then implement the required xpcom interface based on that.

A simpler workaround could be considered if needed, though.

Changed 7 months ago by marco

  • keywords Update.1? added
  • priority changed from normal to high

Ouch, we need support for XUL dialogs. I guess it went lost in the popups handling refactoring.

Jim, I think it's important to get this for Update.1, there are a lot of cases where xulrunner is popping up dialogs. It should not be hard to fix.

Changed 7 months ago by marco

  • summary changed from Alerts (popups) don't show in Gmail and Hotmail, therefore prevents certain actions to XUL modal dialogs are not supported

Changed 7 months ago by jg

  • milestone changed from Never Assigned to Update.1

Changed 7 months ago by dlang

this also affects dialogs asking for passwords or to allow unverified SSL certs

Changed 7 months ago by marco

Changed 7 months ago by marco

  • keywords review? added; Update.1? removed

Simple implementation, it's not perfect but it should work well enough for Update.1.

Changed 7 months ago by marco

Should be in the next joyride.

Changed 7 months ago by cscott

  • blocking set to 5534

(In #5534) I'm reopening, because this should be verified independently of 5487. This is what the 'blocked by' field is for.

Changed 6 months ago by marco

  • priority changed from high to blocker

Changed 6 months ago by erikos

  • cc erikos, marco added
  • owner changed from erikos to ApprovalForUpdate

Went into Web-82.xo (in marco's public rpm repo) which i tested as working (about:config).

Changed 6 months ago by marco

  • owner changed from ApprovalForUpdate to erikos

Approved by me, build inclusion tracked by #5668

Changed 6 months ago by marco

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.