Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#5858 closed enhancement (fixed)

EC needs critial battery voltage shutoff warning

Reported by: rsmith Owned by: rsmith
Priority: high Milestone:
Component: embedded controller Version: Build 708
Keywords: Cc: dilinger
Blocked By: Blocking:
Deployments affected: Action Needed: code
Verified: no

Description

When the battery voltage drops below a critial level the EC just turns off the XO. This prevents battery cell damage. If the SOC % of the battery is somehow incorrect then the user will see the XO just shut off with no warning.

The EC should try to do something nifty with the battery status LED to indicate that an a critical shutdown is about to happen.

Change History (6)

comment:1 Changed 7 years ago by jg

  • Milestone changed from Never Assigned to Update.2
  • Priority changed from normal to high


comment:2 Changed 6 years ago by rsmith

  • Action Needed set to code
  • Cc dilinger added
  • Milestone changed from 8.2.0 (was Update.2) to 9.1.0

This is in my current EC test builds.

Critical battery levels will indicate with red/yellow flash. And throws an SCI of 0x80.

Needs kernel support to read the SCI and pass it along to userspace.

comment:3 in reply to: ↑ description Changed 6 years ago by mwarren

  • Milestone changed from 9.1.0 to 8.2.0 (was Update.2)
  • Version set to Build 708

I'm seeing the same sudden shutoff with candidate-762, Q2E18 on a G1G1 XO-1. Some warning of impending shutoff would be great.

My other laptops start blinking the battery status LED at ~10% SOC, go to sleep at ~6% SOC and then hibernate at ~4% SOC. A software-only fix might be to copy the battery icon from the frame into an always visible state (an overlay similar to the "full-screen" icon in the Browse activity) when the SOC gets low.

comment:4 Changed 6 years ago by mwarren

  • Milestone changed from 8.2.0 (was Update.2) to 9.1.0

Set milestone back to 9.1.0.

comment:5 Changed 5 years ago by rsmith

  • Milestone changed from 9.1.0 to 1.5-F11
  • Resolution set to fixed
  • Status changed from new to closed

In both a2e41 ec code and current Gen 1.5 EC code

comment:6 Changed 5 years ago by anonymous

  • Milestone 1.5-software deleted

Milestone 1.5-software deleted

Note: See TracTickets for help on using tickets.