Ticket #5860 (closed defect: wontfix)

Opened 18 months ago

Last modified 12 months ago

Screenshots and downloaded files do not save activity_id and activity in metadata

Reported by: tamichan Owned by: tomeu
Priority: normal Milestone:
Component: sugar Version: Build 653
Keywords: Cc: Eben, marco
Action Needed: Verified: no
Deployments affected: Blocked By:
Blocking:

Description

Datastore entries created for screenshots (Alt-1) and downloaded files (by Web activity) do not store activity (bundle ID) and activity_id in their metadata.

Change History

in reply to: ↑ description   Changed 18 months ago by tomeu

  • cc Eben, marco added
  • owner changed from marco to tomeu

Replying to tamichan:

Datastore entries created for screenshots (Alt-1) and downloaded files (by Web activity) do not store activity (bundle ID) and activity_id in their metadata.

Why do you think this is a bug?

Some entries in the journal are not the stored state of any activity, but objects that can serve as the initial state of an activity.

Clippings added to the journal cannot have any activity or activity_id, neither. Nor files found in a usb stick.

Eben, am I missing anything?

follow-up: ↓ 3   Changed 18 months ago by tamichan

Thank you for taking care of this ticket.

Although I do not know much about the internals of Sugar, according to thee Low-level Activity API description at http://wiki.laptop.org/go/Low-level_Activity_API , each activity instance needs to set some properties on its top-level window and I thought when Alt-1 key sequence is being processed, the code would be able to obtain activity or activity_id from those properties.

I think there would be no technical problem to obtain activity or activity_id in the case of downloaded filed in the Web activity.

I understand that files found in a usb stick cannot have activity or activity_id.

in reply to: ↑ 2   Changed 18 months ago by tomeu

Replying to tamichan:

Thank you for taking care of this ticket. Although I do not know much about the internals of Sugar, according to thee Low-level Activity API description at http://wiki.laptop.org/go/Low-level_Activity_API , each activity instance needs to set some properties on its top-level window and I thought when Alt-1 key sequence is being processed, the code would be able to obtain activity or activity_id from those properties. I think there would be no technical problem to obtain activity or activity_id in the case of downloaded filed in the Web activity.

The problem here is not to obtain the bundle_id or the activity_id. What happens is that these objects don't make sense to be associated to any existing bundle or activity_id.

The "activity" property means that this entry represents the state of an activity of that bundle id. The "activity_id" property means that, when resumed, that entry needs to be identified by that id, so it can be reshared in the mesh, for example.

Journal entries that represent the state of an activity when it was stopped need to have those properties. This entries can be resumed, and the user would be confronted with the activity as it was when stopped for the last time.

Single objects that never were part of a running activity (downloads, screenshots, files from usb sticks, etc) shouldn't have those attributes as they aren't "frozen activities", but are just data that could be used as the starting point of an activity. Once they have been started like that in Read or Paint, they would gain those properties as at that point became part of an activity's state.

I understand that files found in a usb stick cannot have activity or activity_id.

Right, but that's not because of the impossibility of finding sensible values for those, but because it doesn't make sense.

Hope I explained a bit better. Please see http://wiki.laptop.org/go/OLPC_Human_Interface_Guidelines and http://wiki.laptop.org/go/Journal for more information about the journal. For more information than the available there, you'll have to play with the journal and/or read the code (is relatively simple).

follow-up: ↓ 5   Changed 18 months ago by tamichan

Thanks again for detailed explanation. I was assuming all outcomes of certain activity should have activity and activity_id properties.

BTW, I opened a screenshot in Paint activity, add a line and closed the Paint activity. The change was saved, but the entry still did not not have activity/activity_id properties in the metadata. Should I close this ticket and open another one?

in reply to: ↑ 4   Changed 18 months ago by tomeu

  • status changed from new to closed
  • resolution set to wontfix

Replying to tamichan:

BTW, I opened a screenshot in Paint activity, add a line and closed the Paint activity. The change was saved, but the entry still did not not have activity/activity_id properties in the metadata. Should I close this ticket and open another one?

You are right, I'll open a ticket about this. Thanks!

  Changed 12 months ago by gregorio

  • milestone deleted

Milestone Never Assigned deleted

Note: See TracTickets for help on using tickets.