funky character in AP name means no X

[markvdb]

problem: Trying to associate with an AP named "Gérard" does not work; the "é" confuses /usr/lib/python2.5/ConfigParser.py . It borks out at line 511 with a NoSectionError.

stopgap solution (as suggested by tomeu on #olpc): Remove /home/olpc/.sugar/default/nm/network.cfg , wait for X to respawn. X boots fine

[tomeu]

From irc:

  /usr/lib/python2.5/ConfigParser.py, line 511, in get
 rais NoSectionError(section)
 ConfigParser:NoSectionError No section u'G\xe9rard'

[jg]

Ouch!

As I understand this bug, it causes the system to fail until manual action is taken...

[tomeu]

The following patch fixes the encoding mismatch and also protects us from other unexpected failures in the reading of the network config file:

diff --git a/shell/hardware/nminfo.py b/shell/hardware/nminfo.py
index c1a6326..3a93120 100644
--- a/shell/hardware/nminfo.py
+++ b/shell/hardware/nminfo.py
@@ -394,15 +394,13 @@ class NMInfo(object):
         config.read(self._cfg_file)
         networks = {}
         for name in config.sections():
-            if not isinstance(name, unicode):
-                name = unicode(name)
-            net = Network(name)
             try:
+                net = Network(name)
                 net.read_from_config(config)
                 networks[name] = net
-            except NetworkInvalidError, e:
-                logging.debug("Error: invalid stored network config: %s" % e)
-                del net
+            except Exception, e:
+                logging.error("Error when processing config for the network %s: %r" % (name, e))
+
         del config
         return networks

[dcbw]

Patch looks fine as long as somebody tests it with ASCII and UTF-8/non-English characters. Note that D-Bus will require that the network name be valid UTF-8 when Sugar asks NM to activate the network. You've got to ensure that the network names returned by NetworkManager in the network list (which are going to be UTF-8) match up with the network names saved in the networks.cfg file.

[tomeu]

Thanks Dan for the review.

At last managed to test this by creating an ad-hoc network between two xos, with an ñ in the essid.

Pushed to git. Marco, can you put this in a rpm? Thanks!

[marco]

Tomeu tested this one. I verified that the code is in joyride.