Ticket #5907 (new enhancement)

Opened 6 years ago

Last modified 6 years ago

clicking on activity thumbnail should resume activity

Reported by: dsd Owned by: tomeu
Priority: high Milestone: 8.2.0 (was Update.2)
Component: journal-activity Version:
Keywords: joyride-2240:+ journal-96:+ Cc: tomeu, marco
Action Needed: qa signoff Verified: no
Deployments affected: Blocked By:
Blocking:

Description

When going into the Journal, clicking on a previous Paint activity, and seeing a thumbnail of my artistic excellence, I instinctively clicked on the thumbnail to resume the activity. This did nothing. I would have expected it to resume the activity the same as if I had clicked the Resume button.

Attachments

0001-Clickable-thumbnail-to-resume-activity.patch (0.8 kB) - added by dsd 6 years ago.
this patch implements it
0001--5907-resume-activity-when-preview-is-clicked.patch (1.2 kB) - added by dsd 6 years ago.

Change History

Changed 6 years ago by tomeu

  • cc tomeu added
  • owner changed from tomeu to Eben
  • component changed from journal-activity to interface-design

Changed 6 years ago by marco

I seem to remember we discussed this in a design meeting and everyone thought it was a good idea.

Changed 6 years ago by dsd

this patch implements it

Changed 6 years ago by Eben

  • owner changed from Eben to tomeu
  • component changed from interface-design to journal-activity

Yes, I agree that this is still a good idea to add.

Changed 6 years ago by dsd

  • keywords review? added

Changed 6 years ago by jg

  • cc marco added
  • priority changed from low to high
  • milestone changed from Never Assigned to Future Release

seems like one of those simple crowd pleasers for one line....

Changed 6 years ago by dsd

FWIW I let one of my sisters have a go on my XO and she had exactly the same instinct of clicking the thumbnail. Maybe it's a family thing :)

Changed 6 years ago by dsd

  • keywords r? added; review? removed
  • next_action set to review

This is still unimplemented, I posted a rediffed patch.

Changed 6 years ago by tomeu

  • keywords r+ added; r? removed
  • next_action changed from review to package

Would personally prefer if each widget had its own button-press-event handler or rename the common handler so it doesn't appear to belong to the icon. Reviewed + anyway, but please add a test case before pushing.

Changed 6 years ago by marco

  • milestone changed from Future Release to 8.2.0 (was Update.2)

Changed 6 years ago by dsd

committed and pushed

Changed 6 years ago by erikos

  • keywords joyride-2240:+ journal-96:+ added; r+ removed
  • next_action changed from package to qa signoff

|TestCase|

Go to journal and resume the detailed view of an entry. Click on the thumbnail of the activity to resume it.

Note: See TracTickets for help on using tickets.