Opened 7 years ago

Last modified 6 years ago

#5907 new enhancement

clicking on activity thumbnail should resume activity

Reported by: dsd Owned by: tomeu
Priority: high Milestone: 8.2.0 (was Update.2)
Component: journal-activity Version:
Keywords: joyride-2240:+ journal-96:+ Cc: tomeu, marco
Blocked By: Blocking:
Deployments affected: Action Needed: qa signoff
Verified: no

Description

When going into the Journal, clicking on a previous Paint activity, and seeing a thumbnail of my artistic excellence, I instinctively clicked on the thumbnail to resume the activity. This did nothing. I would have expected it to resume the activity the same as if I had clicked the Resume button.

Attachments (2)

0001-Clickable-thumbnail-to-resume-activity.patch (845 bytes) - added by dsd 7 years ago.
this patch implements it
0001--5907-resume-activity-when-preview-is-clicked.patch (1.2 KB) - added by dsd 6 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 7 years ago by tomeu

  • Cc tomeu added
  • Component changed from journal-activity to interface-design
  • Owner changed from tomeu to Eben

comment:2 Changed 7 years ago by marco

I seem to remember we discussed this in a design meeting and everyone thought it was a good idea.

Changed 7 years ago by dsd

this patch implements it

comment:3 Changed 7 years ago by Eben

  • Component changed from interface-design to journal-activity
  • Owner changed from Eben to tomeu

Yes, I agree that this is still a good idea to add.

comment:4 Changed 7 years ago by dsd

  • Keywords review? added

comment:5 Changed 7 years ago by jg

  • Cc marco added
  • Milestone changed from Never Assigned to Future Release
  • Priority changed from low to high

seems like one of those simple crowd pleasers for one line....

comment:6 Changed 7 years ago by dsd

FWIW I let one of my sisters have a go on my XO and she had exactly the same instinct of clicking the thumbnail. Maybe it's a family thing :)

comment:7 Changed 6 years ago by dsd

  • Action Needed set to review
  • Keywords r? added; review? removed

This is still unimplemented, I posted a rediffed patch.

comment:8 Changed 6 years ago by tomeu

  • Action Needed changed from review to package
  • Keywords r+ added; r? removed

Would personally prefer if each widget had its own button-press-event handler or rename the common handler so it doesn't appear to belong to the icon. Reviewed + anyway, but please add a test case before pushing.

comment:9 Changed 6 years ago by marco

  • Milestone changed from Future Release to 8.2.0 (was Update.2)

comment:10 Changed 6 years ago by dsd

committed and pushed

comment:11 Changed 6 years ago by erikos

  • Action Needed changed from package to qa signoff
  • Keywords joyride-2240:+ journal-96:+ added; r+ removed

|TestCase|

Go to journal and resume the detailed view of an entry. Click on the thumbnail of the activity to resume it.

Note: See TracTickets for help on using tickets.